Conversation
gengjiawen
approved these changes
May 17, 2020
Notable changes: - A DEBUG() macro and UVWASI_DEBUG_LOG build option have been added to improve debugging. - Path length restrictions have been removed across the codebase. - Initial support for poll_oneoff() has been added on all platforms. The implementation is based on uv_poll_t's. - A new uvwasi_size_t has been introduced across the WASI system call API. This provides consistent 32-bit size_t's. - The cmake test targets are now only generated if uvwasi is the root project to avoid conflicts with targets from embedders. - uv.h has been removed from the public headers. - A serialization/deserialization API has been added to simplify the process of working with WASM memory. This also hides many WASI <--> WASM interfacing implementation details from embedders. - A memory corruption bug on Windows related to path resolution has been fixed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notable changes:
DEBUG()macro andUVWASI_DEBUG_LOGbuild option have beenadded to improve debugging. (introduce debug macro #113)
poll_oneoff()has been added on allplatforms. The implementation is based on
uv_poll_t's. (src: add initial poll_oneoff() implementation #117)uvwasi_size_thas been introduced across the WASI systemcall API. This provides consistent 32-bit
size_t's. (migrate from size_t to uvwasi_size_t #121)root project to avoid conflicts with targets from embedders. (build: conditionally create test targets #120)
uv.hhas been removed from the public headers. (remove uv.h from public headers #122)the process of working with WASM memory. This also hides many
WASI <--> WASM interfacing implementation details from
embedders. (add serdes API #94) and (updates to serdes APIs #126)
has been fixed. (reset pointer to prevent memory corruption #127)