Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(fetch): FormData #961

Merged
merged 18 commits into from
Aug 17, 2021
Merged

feat(fetch): FormData #961

merged 18 commits into from
Aug 17, 2021

Conversation

ronag
Copy link
Member

@ronag ronag commented Aug 15, 2021

No description provided.

@ronag ronag added this to the stable fetch milestone Aug 15, 2021
@ronag ronag requested a review from Ethan-Arrowood August 15, 2021 12:18
@codecov-commenter
Copy link

codecov-commenter commented Aug 15, 2021

Codecov Report

Merging #961 (08884f9) into main (3b52761) will decrease coverage by 2.56%.
The diff coverage is 12.38%.

❗ Current head 08884f9 differs from pull request most recent head 4b90012. Consider uploading reports for the commit 4b90012 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main     #961      +/-   ##
==========================================
- Coverage   81.42%   78.85%   -2.57%     
==========================================
  Files          35       37       +2     
  Lines        3397     3637     +240     
==========================================
+ Hits         2766     2868     +102     
- Misses        631      769     +138     
Impacted Files Coverage Δ
lib/fetch/body.js 20.39% <7.01%> (-8.48%) ⬇️
lib/fetch/formdata.js 11.11% <11.11%> (ø)
lib/fetch/file.js 30.00% <30.00%> (ø)
index.js 100.00% <100.00%> (ø)
lib/fetch/index.js 58.10% <0.00%> (+1.77%) ⬆️
lib/fetch/util.js 55.20% <0.00%> (+3.35%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9674488...4b90012. Read the comment docs.

@ronag ronag force-pushed the formdata branch 2 times, most recently from 5a9b2f8 to 0d5ff19 Compare August 16, 2021 07:49
@ronag ronag requested a review from mcollina August 16, 2021 07:50
@ronag ronag mentioned this pull request Aug 16, 2021
@ronag ronag force-pushed the formdata branch 2 times, most recently from ec60042 to 4ccaa4f Compare August 16, 2021 07:57
@ronag ronag changed the title feat(fetch): initial FormData support feat(fetch): FormData Aug 16, 2021
@ronag ronag force-pushed the formdata branch 3 times, most recently from ee1efec to daa8344 Compare August 16, 2021 08:00
@ronag ronag force-pushed the formdata branch 4 times, most recently from 08884f9 to 4b90012 Compare August 16, 2021 11:26
@ronag ronag requested a review from mcollina August 16, 2021 11:31
@ronag ronag mentioned this pull request Aug 16, 2021
6 tasks
@ronag ronag force-pushed the formdata branch 3 times, most recently from a9adf6f to 8fc5cf7 Compare August 16, 2021 13:31
@ronag
Copy link
Member Author

ronag commented Aug 17, 2021

@mcollina

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is extremely low on test for the amount of things it does.

@ronag
Copy link
Member Author

ronag commented Aug 17, 2021

This is extremely low on test for the amount of things it does.

I intend to go through all of the fetch code and increase coverage once most of the functionality has landed (I guess this is the last piece).

Landing it without tests also allows other contributors to help with that.

@ronag ronag merged commit 52a26c8 into main Aug 17, 2021
@ronag ronag deleted the formdata branch October 28, 2021 08:10
KhafraDev pushed a commit to KhafraDev/undici that referenced this pull request Jun 23, 2022
* feat(fetch): FormData

* fixup: globalThis

* fixup

* fixup: backpressure

* fixup

* fixup

* fixup

* fixup

* fixup

* fixup

* fixup

* fixup

* fixup

* fixup

* fixup

* fixup

* fixup: remove dicer

* fixup
crysmags pushed a commit to crysmags/undici that referenced this pull request Feb 27, 2024
* feat(fetch): FormData

* fixup: globalThis

* fixup

* fixup: backpressure

* fixup

* fixup

* fixup

* fixup

* fixup

* fixup

* fixup

* fixup

* fixup

* fixup

* fixup

* fixup

* fixup: remove dicer

* fixup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants