fetch: process content-encoding header only if relevant #4496
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4496 +/- ##
==========================================
- Coverage 93.53% 93.53% -0.01%
==========================================
Files 103 103
Lines 32349 32348 -1
==========================================
- Hits 30257 30256 -1
Misses 2092 2092 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Ethan-Arrowood
approved these changes
Sep 5, 2025
| "test": "npm run test:javascript && cross-env NODE_V8_COVERAGE= npm run test:typescript", | ||
| "test:javascript": "npm run test:javascript:no-jest && npm run test:jest", | ||
| "test:javascript:no-jest": "npm run generate-pem && npm run test:unit && npm run test:node-fetch && npm run test:cache && npm run test:cache-interceptor && npm run test:interceptors && npm run test:fetch && npm run test:cookies && npm run test:eventsource && npm run test:subresource-integrity && npm run test:wpt && npm run test:websocket && npm run test:node-test && npm run test:cache-tests", | ||
| "test:javascript:no-jest": "npm run generate-pem && npm run test:unit && npm run test:fetch && npm run test:node-fetch && npm run test:cache && npm run test:cache-interceptor && npm run test:interceptors && npm run test:cookies && npm run test:eventsource && npm run test:subresource-integrity && npm run test:wpt && npm run test:websocket && npm run test:node-test && npm run test:cache-tests", |
Collaborator
There was a problem hiding this comment.
is this just moving test:fetch earlier in the order? Does that really matter? i hope the tests are independant
Contributor
Author
There was a problem hiding this comment.
they are, but it makes more sense to test the fetch stuff consequently.
Comment on lines
+20
to
+21
| req.headers['accept-encoding'] === 'deflate, gzip' || | ||
| req.headers['accept-encoding'] === 'DeFlAtE, GzIp' |
Collaborator
There was a problem hiding this comment.
Suggested change
| req.headers['accept-encoding'] === 'deflate, gzip' || | |
| req.headers['accept-encoding'] === 'DeFlAtE, GzIp' | |
| req.headers['accept-encoding']?.toLowerCase() === 'deflate, gzip' |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This relates to...
Rationale
Changes
Features
Bug Fixes
Breaking Changes and Deprecations
Status