feat: add install() function to type definitions #4384
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metcoder95
approved these changes
Aug 3, 2025
|
Do we really need a separate install.d.ts for a trivial function? |
mcollina
requested changes
Aug 4, 2025
jsaguet
force-pushed
the
feat/add-install-to-type-definitions
branch
from
dba3883 to
b2ef8a0
Compare
jsaguet
force-pushed
the
feat/add-install-to-type-definitions
branch
from
b2ef8a0 to
de4edaf
Compare
|
I implemented the changes. |
metcoder95
approved these changes
Aug 4, 2025
Ethan-Arrowood
approved these changes
Aug 5, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This relates to...
Rationale
The install function is not available in undici types so when trying to use it in a TS project, we have to add @ts-ignore or similar to be able to use it.
Changes
Adds install function to d.ts
Features
Bug Fixes
Breaking Changes and Deprecations
Status