refactor: port redirect handler to new hooks #3879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ronag
requested review from
mcollina and
metcoder95
and removed request for
mcollina
ronag
force-pushed
the
redirect-hooks
branch
8 times, most recently
from
9ad0853 to
5946392
Compare
ronag
force-pushed
the
redirect-hooks
branch
from
5946392 to
b82c7e7
Compare
mcollina
reviewed
Nov 25, 2024
lib/core/util.js
Outdated
| } | ||
| } | ||
| return ret | ||
| } |
There was a problem hiding this comment.
This logic seems very complex. why is it needed?
There was a problem hiding this comment.
To normalize different headers shapes?
DTrombett
reviewed
Nov 25, 2024
ronag
force-pushed
the
redirect-hooks
branch
from
b5f52ff to
4312c21
Compare
ronag
force-pushed
the
redirect-hooks
branch
8 times, most recently
from
395ff5f to
7b27263
Compare
ronag
force-pushed
the
redirect-hooks
branch
from
7b27263 to
465bc5d
Compare
This was referenced Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This relates to...
Rationale
Changes
Features
Bug Fixes
Breaking Changes and Deprecations
Status