Skip to content

ci: node nightly test should use node 23#3248

Merged
Uzlopak merged 1 commit intonodejs:mainfrom
Uzlopak:upgrade-nightly-tests
May 12, 2024
Merged

ci: node nightly test should use node 23#3248
Uzlopak merged 1 commit intonodejs:mainfrom
Uzlopak:upgrade-nightly-tests

Conversation

@Uzlopak
Copy link
Contributor

@Uzlopak Uzlopak commented May 12, 2024

today again i got an email that our nightly fails. checked it and wondered why node nightly from 24 april was used. checked the node page and saw, that since we have node 23, no node 22 nightlies are published. So we have to change the target.

Also here I wonder if the following condition is correct:

if: ${{ always() && (needs.test-linux.result == 'failure' && needs.test-windows.result == 'failure' && needs.test-macos.result == 'failure') }}

I would actually say, that it should be or conditions and not and conditions. If the tests fail in windows but mac and linux pass, as it is now, then we dont get an issue created. Rn i still get an email that it failed.

Maybe @mweberxyz share his opinion?

Maybe can be taken care in a follow up.

Copy link
Member

@metcoder95 metcoder95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I remember is was done in this way to reduce false positives as we had them in the past, remember @mweberxyz attempted to fix them.

@Uzlopak
Copy link
Contributor Author

Uzlopak commented May 12, 2024

Ah, ok. Then lets merge this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants