fix: bad client destroy on servername change #3066
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@metcoder95 any chance you can help me with a test? |
ronag
force-pushed
the
bad-client-destroy
branch
from
e1950a0 to
40e866f
Compare
ronag
force-pushed
the
bad-client-destroy
branch
from
40e866f to
ae19601
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3066 +/- ##
==========================================
+ Coverage 93.51% 93.79% +0.28%
==========================================
Files 89 89
Lines 24331 24337 +6
==========================================
+ Hits 22754 22828 +74
+ Misses 1577 1509 -68 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
metcoder95
approved these changes
Apr 7, 2024
Member
metcoder95
left a comment
metcoder95
left a comment
There was a problem hiding this comment.
Done @ronag can you take a look?
Member
|
I'll work for adding a test for h2 in another PR 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #3065
This relates to...
Rationale
Changes
Features
Bug Fixes
Breaking Changes and Deprecations
Status