update spec & wpts #2482

KhafraDev · 2023-12-01T04:13:53Z

Adds range header support to blob: urls.
Fixes a couple regressions
Adds support for byte streams (and therefore byob mode) in request bodies. MDN link explaining the differences.

restore fetch error debug time

test/wpt/tests/fetch/private-network-access/resources/opener.html

codecov-commenter · 2023-12-01T04:16:33Z

Codecov Report

Attention: 143 lines in your changes are missing coverage. Please review.

Comparison is base (e39a632) 85.54% compared to head (b5dcb40) 84.23%.
Report is 129 commits behind head on main.

Files	Patch %	Lines
lib/fetch/index.js	55.45%	49 Missing ⚠️
lib/fetch/util.js	23.72%	45 Missing ⚠️
lib/handler/RetryHandler.js	73.91%	30 Missing ⚠️
lib/fetch/headers.js	88.63%	5 Missing ⚠️
lib/api/readable.js	80.00%	4 Missing ⚠️
lib/client.js	92.10%	3 Missing ⚠️
lib/core/util.js	90.47%	2 Missing ⚠️
lib/fetch/request.js	90.47%	2 Missing ⚠️
lib/core/request.js	96.29%	1 Missing ⚠️
lib/fetch/dataURL.js	85.71%	1 Missing ⚠️
... and 1 more

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2482      +/-   ##
==========================================
- Coverage   85.54%   84.23%   -1.32%     
==========================================
  Files          76       76              
  Lines        6858     7156     +298     
==========================================
+ Hits         5867     6028     +161     
- Misses        991     1128     +137

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

lib/fetch/dataURL.js

debadree25 · 2023-12-01T05:58:35Z

One of the cases to consider in bytes stream is to call c.byobRequest?.respond(0); after calling controller.close() you can take a look at https://github.com/nodejs/node/pull/49713/files maybe could be helpful?

KhafraDev · 2023-12-01T18:18:42Z

Thank you! That fixed most of the errors!

KhafraDev · 2023-12-01T19:23:18Z

If we're going to follow the idea of big fetch changes being semver-major, this one is definitely a major change

ronag

16 eol was semver major anyway so this is pretty good timing.

ronag · 2023-12-01T19:32:40Z

Did you go through the spec and apply any new changes we might be missing?

KhafraDev · 2023-12-01T19:35:11Z

as many as I needed to in order to pass the WPTs, I'm probably missing some but this is fast forwarding us a couple months

ronag · 2023-12-01T19:36:04Z

CI failing?

KhafraDev · 2023-12-01T19:36:54Z

windows 20:

 not ok 74 - test/redirect-request.js # time=1809.245ms

windows 18:

 not ok 74 - test/redirect-request.js # time=10253.305ms

KhafraDev · 2023-12-01T19:38:26Z

(not related to the WPTs, they all passed on ubuntu 18/20)

* update spec & wpts restore fetch error debug time * fix some test failures for others!! * fix some test failures for others!! * fix most remaining failures * fix remaining WPT fail * fix fetching blob * mark websocket WPTs as failing

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [undici](https://undici.nodejs.org) ([source](https://github.com/nodejs/undici)) | resolutions | major | [`^5.28.3` -> `^6.0.0`](https://renovatebot.com/diffs/npm/undici/5.28.3/6.9.0) | --- ### Release Notes <details> <summary>nodejs/undici (undici)</summary> ### [`v6.9.0`](https://github.com/nodejs/undici/releases/tag/v6.9.0) [Compare Source](nodejs/undici@v6.8.0...v6.9.0) #### What's Changed - feat: add new dispatch compose by [@metcoder95](https://github.com/metcoder95) in nodejs/undici#2826 - ci: add macos-latest to test-matrix by [@Uzlopak](https://github.com/Uzlopak) in nodejs/undici#2952 - types: align RequestInit.body type with lib.dom.ts by [@jdufresne](https://github.com/jdufresne) in nodejs/undici#2956 - ci: pin versions of github actions by [@UlisesGascon](https://github.com/UlisesGascon) in nodejs/undici#2957 - fetch: improve output for FormData, Response, Request by [@mertcanaltin](https://github.com/mertcanaltin) in nodejs/undici#2955 - perf: optimize collectASequenceOfBytes by [@tsctx](https://github.com/tsctx) in nodejs/undici#2958 #### New Contributors - [@jdufresne](https://github.com/jdufresne) made their first contribution in nodejs/undici#2956 - [@UlisesGascon](https://github.com/UlisesGascon) made their first contribution in nodejs/undici#2957 **Full Changelog**: nodejs/undici@v6.8.0...v6.9.0 ### [`v6.8.0`](https://github.com/nodejs/undici/releases/tag/v6.8.0) [Compare Source](nodejs/undici@v6.7.1...v6.8.0) #### What's Changed - fix: send correct SNI for proxy connections by [@chrros95](https://github.com/chrros95) in nodejs/undici#2939 - build(deps): bump node from `8bf9240` to `7bfef1d` in /build by [@dependabot](https://github.com/dependabot) in nodejs/undici#2937 - fetch: improve util.inspect output for web specifications by [@mertcanaltin](https://github.com/mertcanaltin) in nodejs/undici#2938 - ci: fix broken ci on windows and node v21 because of libuv bug by [@Uzlopak](https://github.com/Uzlopak) in nodejs/undici#2941 - perf: improve getResolveErrorBodyCallback by [@Uzlopak](https://github.com/Uzlopak) in nodejs/undici#2940 - fix: don't assign kAgent twice by [@ronag](https://github.com/ronag) in nodejs/undici#2942 - perf: dump immediatly if known size exceeds limit by [@ronag](https://github.com/ronag) in nodejs/undici#2882 - build(deps): bump node from `7bfef1d` to `4999fa1` in /build by [@dependabot](https://github.com/dependabot) in nodejs/undici#2946 - try to fix windows failure by [@ronag](https://github.com/ronag) in nodejs/undici#2950 - perf: improve parsing form-data by [@tsctx](https://github.com/tsctx) in nodejs/undici#2944 #### New Contributors - [@chrros95](https://github.com/chrros95) made their first contribution in nodejs/undici#2939 **Full Changelog**: nodejs/undici@v6.7.1...v6.8.0 ### [`v6.7.1`](https://github.com/nodejs/undici/releases/tag/v6.7.1) [Compare Source](nodejs/undici@v6.7.0...v6.7.1) #### What's Changed - fetch: use EOL of os-module by [@Uzlopak](https://github.com/Uzlopak) in nodejs/undici#2915 - ci: only send codecov from ubuntu and node by [@Uzlopak](https://github.com/Uzlopak) in nodejs/undici#2914 - tests: improve skip for unix.js tests, remove skipped tests by [@Uzlopak](https://github.com/Uzlopak) in nodejs/undici#2916 - chore: fix typo in isHistoryNavigation comments by [@kachick](https://github.com/kachick) in nodejs/undici#2920 - fix(benchmark): set body correctly by [@tsctx](https://github.com/tsctx) in nodejs/undici#2918 - chore: increase test coverage to 100% for /lib/api/api-request.js by [@Uzlopak](https://github.com/Uzlopak) in nodejs/undici#2912 - fix: chunksDecode cuts off 3 characters at the end if having BOM by [@Uzlopak](https://github.com/Uzlopak) in nodejs/undici#2922 - docs: clarify URI parsing behavior of ProxyAgent constructor by [@rossilor95](https://github.com/rossilor95) in nodejs/undici#2893 - implement sync formdata parser by [@KhafraDev](https://github.com/KhafraDev) in nodejs/undici#2911 - Fix docs links and add examples to sidebar by [@tastypackets](https://github.com/tastypackets) in nodejs/undici#2895 - doc: update diagnostics channel request headers type change by [@jessezhang91](https://github.com/jessezhang91) in nodejs/undici#2925 - perf: optimize getResolveErrorBodyCallback by [@tsctx](https://github.com/tsctx) in nodejs/undici#2921 - override request dispatcher from init by [@matthieusieben](https://github.com/matthieusieben) in nodejs/undici#2928 - add busboy tests by [@KhafraDev](https://github.com/KhafraDev) in nodejs/undici#2924 - fix(benchmark): make it fair by [@tsctx](https://github.com/tsctx) in nodejs/undici#2929 - Revert "chore: remove no-simd wasm" by [@Uzlopak](https://github.com/Uzlopak) in nodejs/undici#2935 - build(deps): bump node from `d3271e4` to `8bf9240` in /build by [@dependabot](https://github.com/dependabot) in nodejs/undici#2936 - Flip link between docs and README by [@mcollina](https://github.com/mcollina) in nodejs/undici#2933 #### New Contributors - [@kachick](https://github.com/kachick) made their first contribution in nodejs/undici#2920 - [@tastypackets](https://github.com/tastypackets) made their first contribution in nodejs/undici#2895 - [@jessezhang91](https://github.com/jessezhang91) made their first contribution in nodejs/undici#2925 - [@matthieusieben](https://github.com/matthieusieben) made their first contribution in nodejs/undici#2928 **Full Changelog**: nodejs/undici@v6.7.0...v6.7.1 ### [`v6.7.0`](https://github.com/nodejs/undici/releases/tag/v6.7.0) [Compare Source](nodejs/undici@v6.6.2...v6.7.0) #### What's Changed - test: remove t.diagnostics() calls in push-dont-push.js test by [@Uzlopak](https://github.com/Uzlopak) in nodejs/undici#2715 - fix: fix flaky debug test by [@Uzlopak](https://github.com/Uzlopak) in nodejs/undici#2714 - fix: HTTP2 tweaks by [@metcoder95](https://github.com/metcoder95) in nodejs/undici#2711 - test: improve cookie tests by [@Uzlopak](https://github.com/Uzlopak) in nodejs/undici#2693 - test: response.url after redirect is set to target url by [@Uzlopak](https://github.com/Uzlopak) in nodejs/undici#2716 - chore: remove mocha and chai by [@Uzlopak](https://github.com/Uzlopak) in nodejs/undici#2696 - test: replace t.pass with t.ok by [@Uzlopak](https://github.com/Uzlopak) in nodejs/undici#2721 - perf: remove redundant operation in FormData by [@tsctx](https://github.com/tsctx) in nodejs/undici#2726 - Add support for passing iterable objects as headers by [@JaoodxD](https://github.com/JaoodxD) in nodejs/undici#2708 - chore: refine esbuild & node detection by [@mochaaP](https://github.com/mochaaP) in nodejs/undici#2677 - chore: rephrase some comments by [@Uzlopak](https://github.com/Uzlopak) in nodejs/undici#2717 - test: replace t.type with t.ok and instanceof by [@Uzlopak](https://github.com/Uzlopak) in nodejs/undici#2720 - remove useless options in web streams by [@KhafraDev](https://github.com/KhafraDev) in nodejs/undici#2729 - Let's add superagent to the benchmark. closes [#2730](nodejs/undici#2730) by [@eddienubes](https://github.com/eddienubes) in nodejs/undici#2731 - convert node build to latin1 by [@KhafraDev](https://github.com/KhafraDev) in nodejs/undici#2673 - simplify formData body parsing by [@KhafraDev](https://github.com/KhafraDev) in nodejs/undici#2735 - chore: migrate a batch of tests to node test runner no. 1 by [@Uzlopak](https://github.com/Uzlopak) in nodejs/undici#2719 - chore: migrate a batch of tests to node test runner no. 2 by [@Uzlopak](https://github.com/Uzlopak) in nodejs/undici#2737 - chore: migrate a batch of tests to node test runner no. 4 by [@Uzlopak](https://github.com/Uzlopak) in nodejs/undici#2739 - chore: migrate a batch of tests to node test runner no. 5 by [@Uzlopak](https://github.com/Uzlopak) in nodejs/undici#2740 - chore: migrate a batch of tests to node test runner no. 3 by [@Uzlopak](https://github.com/Uzlopak) in nodejs/undici#2738 - chore: migrate a batch of tests to node test runner no. 6 by [@Uzlopak](https://github.com/Uzlopak) in nodejs/undici#2741 - chore: migrate a batch of tests to node test runner no. 8 by [@Uzlopak](https://github.com/Uzlopak) in nodejs/undici#2744 - chore: migrate a batch of tests to node test runner no. 7 by [@Uzlopak](https://github.com/Uzlopak) in nodejs/undici#2742 - build(deps-dev): bump cronometro from 2.0.2 to 3.0.1 by [@dependabot](https://github.com/dependabot) in nodejs/undici#2749 - perf: always use the same prototype Iterator by [@tsctx](https://github.com/tsctx) in nodejs/undici#2743 - chore: migrate a batch of tests to node test runner no. 9, remove tap by [@Uzlopak](https://github.com/Uzlopak) in nodejs/undici#2746 - chore: remove usage of http-errors in proxy example by [@Uzlopak](https://github.com/Uzlopak) in nodejs/undici#2753 - fix: dont ship wasm files of llhttp via npm by [@Uzlopak](https://github.com/Uzlopak) in nodejs/undici#2752 - fix: handle request body as late as possible by [@ronag](https://github.com/ronag) in nodejs/undici#2734 - perf(tree): avoid recursive calls by [@tsctx](https://github.com/tsctx) in nodejs/undici#2755 - docs: fix favicon by [@Uzlopak](https://github.com/Uzlopak) in nodejs/undici#2758 - chore: use mermaid engine and mermaid in markdown by [@Uzlopak](https://github.com/Uzlopak) in nodejs/undici#2759 - chore: remove sinon dev dependency by [@Uzlopak](https://github.com/Uzlopak) in nodejs/undici#2767 - tests: skip test/node-test/debug on node 21.6.2 and windows by [@Uzlopak](https://github.com/Uzlopak) in nodejs/undici#2765 - chore: improve usage of skip in tests by [@Uzlopak](https://github.com/Uzlopak) in nodejs/undici#2761 - feat: improve mock error breadcrumbs by [@rossilor95](https://github.com/rossilor95) in nodejs/undici#2774 - expose MessageEvent in fetch bundle by [@KhafraDev](https://github.com/KhafraDev) in nodejs/undici#2770 - test: always exit with 0 when running in Node's Daily WPT Report CI job by [@panva](https://github.com/panva) in nodejs/undici#2778 - fix: add node prefix for util to fix issue in env with min version node 18 by [@riderx](https://github.com/riderx) in nodejs/undici#2775 - perf: improve perf of parseRawHeaders by [@Uzlopak](https://github.com/Uzlopak) in nodejs/undici#2781 - fix: make mock-agent.js test more resilient by [@Uzlopak](https://github.com/Uzlopak) in nodejs/undici#2780 - chore: make some test run even without internet connection by [@Uzlopak](https://github.com/Uzlopak) in nodejs/undici#2786 - mock: improve validateReplyParameters by [@Uzlopak](https://github.com/Uzlopak) in nodejs/undici#2783 - perf: improve TernarySearchTree by [@Uzlopak](https://github.com/Uzlopak) in nodejs/undici#2782 - fix: convert HeadersInit to sequence/dictionary correctly by [@KhafraDev](https://github.com/KhafraDev) in nodejs/undici#2784 - chore: improve getFieldValue by [@Uzlopak](https://github.com/Uzlopak) in nodejs/undici#2785 - Add RetryHandler to sidebar by [@mcollina](https://github.com/mcollina) in nodejs/undici#2797 - Add RetryAgent by [@mcollina](https://github.com/mcollina) in nodejs/undici#2798 - build(deps): bump step-security/harden-runner from 2.6.0 to 2.7.0 by [@dependabot](https://github.com/dependabot) in nodejs/undici#2690 - build(deps): bump actions/checkout from 4.1.0 to 4.1.1 by [@dependabot](https://github.com/dependabot) in nodejs/undici#2393 - build(deps): bump actions/upload-artifact from 3.1.3 to 4.3.1 by [@dependabot](https://github.com/dependabot) in nodejs/undici#2799 - build(deps): bump node from 20-alpine to 21-alpine in /build by [@dependabot](https://github.com/dependabot) in nodejs/undici#2803 - perf: improve sort algorithm by [@tsctx](https://github.com/tsctx) in nodejs/undici#2756 - refactor: move web stuff into their own folder by [@ronag](https://github.com/ronag) in nodejs/undici#2793 - `s/ dispactgher/dispatcher/` by [@steveluscher](https://github.com/steveluscher) in nodejs/undici#2807 - Use paralellelRequests instead of connections to calculate req/sec in benchmarks by [@mcollina](https://github.com/mcollina) in nodejs/undici#2800 - Split out documentation into separate directory by [@Ethan-Arrowood](https://github.com/Ethan-Arrowood) in nodejs/undici#2788 - build(deps): bump fastify/github-action-merge-dependabot from 3.9.1 to 3.10.1 by [@dependabot](https://github.com/dependabot) in nodejs/undici#2820 - build(deps): bump actions/dependency-review-action from 4.0.0 to 4.1.3 by [@dependabot](https://github.com/dependabot) in nodejs/undici#2821 - build(deps): bump github/codeql-action from 3.23.2 to 3.24.4 by [@dependabot](https://github.com/dependabot) in nodejs/undici#2818 - build(deps): bump actions/setup-node from 4.0.1 to 4.0.2 by [@dependabot](https://github.com/dependabot) in nodejs/undici#2819 - fix: move CNAME and .nojekyll to root by [@Uzlopak](https://github.com/Uzlopak) in nodejs/undici#2822 - remove all fetchParam event handlers by [@KhafraDev](https://github.com/KhafraDev) in nodejs/undici#2823 - feat: refactor ProxyAgent constructor to also accept single URL argument by [@rossilor95](https://github.com/rossilor95) in nodejs/undici#2810 - fix: isCTLExcludingHtab by [@Uzlopak](https://github.com/Uzlopak) in nodejs/undici#2790 - refactor: move files into logical folders by [@ronag](https://github.com/ronag) in nodejs/undici#2813 - refactor: move fixed-queeu to dispatcher and rm node folder by [@ronag](https://github.com/ronag) in nodejs/undici#2827 - chore: create package.json in benchmarks by [@Uzlopak](https://github.com/Uzlopak) in nodejs/undici#2766 - build(deps): bump github/codeql-action from 3.24.4 to 3.24.5 by [@dependabot](https://github.com/dependabot) in nodejs/undici#2829 - chore: use lts for pubish types workflow by [@Uzlopak](https://github.com/Uzlopak) in nodejs/undici#2830 - add dispatcher option to Request by [@KhafraDev](https://github.com/KhafraDev) in nodejs/undici#2831 - fix url referrer wpt by [@KhafraDev](https://github.com/KhafraDev) in nodejs/undici#2832 - refactor: remove own sort logic by [@tsctx](https://github.com/tsctx) in nodejs/undici#2834 - fix(fetch): prevent crash when `fetch` is aborted with `null` as the `AbortSignal's` `reason` by [@steveluscher](https://github.com/steveluscher) in nodejs/undici#2833 - refactor: avoid http2 dynamic dispatch in socket handlers by [@ronag](https://github.com/ronag) in nodejs/undici#2839 - build(deps-dev): bump proxy from 1.0.2 to 2.1.1 by [@dependabot](https://github.com/dependabot) in nodejs/undici#2137 - perf(tree): reduce overhead of build TernarySearchTree by [@tsctx](https://github.com/tsctx) in nodejs/undici#2840 - webidl: implement resizable arraybuffer checks by [@KhafraDev](https://github.com/KhafraDev) in nodejs/undici#2094 - websocket server only needs to reply with a single subprotocol by [@KhafraDev](https://github.com/KhafraDev) in nodejs/undici#2845 - unite webidl stringification by [@KhafraDev](https://github.com/KhafraDev) in nodejs/undici#2843 - fix: deflake connect-timeout test by [@Uzlopak](https://github.com/Uzlopak) in nodejs/undici#2851 - fix: coverage reporting by [@Uzlopak](https://github.com/Uzlopak) in nodejs/undici#2763 - fix: pipelining logic is not relevant for h2 by [@ronag](https://github.com/ronag) in nodejs/undici#2850 - processBody doesn't need to return a promise by [@KhafraDev](https://github.com/KhafraDev) in nodejs/undici#2858 - refactor: split client into client-h1/h2 by [@ronag](https://github.com/ronag) in nodejs/undici#2848 - ci: fix concurrency by [@Uzlopak](https://github.com/Uzlopak) in nodejs/undici#2862 - perf: improve performance of isValidSubprotocol by [@Uzlopak](https://github.com/Uzlopak) in nodejs/undici#2861 - perf: reuse TextDecoder instance by [@Uzlopak](https://github.com/Uzlopak) in nodejs/undici#2863 - chore: restructure benchmarks, use kebab-case by [@Uzlopak](https://github.com/Uzlopak) in nodejs/undici#2864 - cookies: improve perf of toIMFDate by [@Uzlopak](https://github.com/Uzlopak) in nodejs/undici#2867 - cookies: fix validateCookiePath by [@Uzlopak](https://github.com/Uzlopak) in nodejs/undici#2866 - refactor: move out more h2 from core client by [@ronag](https://github.com/ronag) in nodejs/undici#2860 - mock: improve test coverage of buildHeadersFromArray by [@Uzlopak](https://github.com/Uzlopak) in nodejs/undici#2872 - fix: remove broken build request hack by [@ronag](https://github.com/ronag) in nodejs/undici#2874 - chore: filenames should use kebab-case by [@Uzlopak](https://github.com/Uzlopak) in nodejs/undici#2873 - refactor: split out last h1 specific code from core by [@ronag](https://github.com/ronag) in nodejs/undici#2876 - fix: make pipelining limit work for h2 by [@ronag](https://github.com/ronag) in nodejs/undici#2875 - fix: http2 doesn't have pipelining queue by [@ronag](https://github.com/ronag) in nodejs/undici#2878 - fix: minor connect cleanup by [@ronag](https://github.com/ronag) in nodejs/undici#2877 - Request headers types by [@JaoodxD](https://github.com/JaoodxD) in nodejs/undici#2879 - ci: remove concurrency by [@Uzlopak](https://github.com/Uzlopak) in nodejs/undici#2880 - fix: prefer queueMicrotask by [@ronag](https://github.com/ronag) in nodejs/undici#2881 - chore: remove no-simd wasm by [@Uzlopak](https://github.com/Uzlopak) in nodejs/undici#2871 - cookies: improve validateCookieValue by [@Uzlopak](https://github.com/Uzlopak) in nodejs/undici#2883 - cookies: improve validateCookieName by [@Uzlopak](https://github.com/Uzlopak) in nodejs/undici#2884 - Properly parse set-cookie header using http2 by [@jeanp413](https://github.com/jeanp413) in nodejs/undici#2886 - doc deprecate bodymixin.formData by [@KhafraDev](https://github.com/KhafraDev) in nodejs/undici#2892 - perf: optimize check invalid field-vchar by [@tsctx](https://github.com/tsctx) in nodejs/undici#2889 - build(deps): bump github/codeql-action from 3.24.5 to 3.24.6 by [@dependabot](https://github.com/dependabot) in nodejs/undici#2897 - fix issue 2898 by [@KhafraDev](https://github.com/KhafraDev) in nodejs/undici#2900 - tests: ignore catch block when requiring crypto module by [@Uzlopak](https://github.com/Uzlopak) in nodejs/undici#2901 - websocket: remove dead code in parseCloseBody by [@Uzlopak](https://github.com/Uzlopak) in nodejs/undici#2902 - fix: tests dont need process.exit by [@Uzlopak](https://github.com/Uzlopak) in nodejs/undici#2909 - chore: remove proxyquire by [@Uzlopak](https://github.com/Uzlopak) in nodejs/undici#2906 - chore: remove import-fresh as devDependency by [@Uzlopak](https://github.com/Uzlopak) in nodejs/undici#2908 - perf(headers): a single set-cookie by [@tsctx](https://github.com/tsctx) in nodejs/undici#2903 - websocket: improve .close() by [@Uzlopak](https://github.com/Uzlopak) in nodejs/undici#2865 - feat: add sending data benchmark by [@tsctx](https://github.com/tsctx) in nodejs/undici#2905 - ci: integrate workflows into nodejs.yml by [@Uzlopak](https://github.com/Uzlopak) in nodejs/undici#2899 #### New Contributors - [@JaoodxD](https://github.com/JaoodxD) made their first contribution in nodejs/undici#2708 - [@eddienubes](https://github.com/eddienubes) made their first contribution in nodejs/undici#2731 - [@riderx](https://github.com/riderx) made their first contribution in nodejs/undici#2775 - [@steveluscher](https://github.com/steveluscher) made their first contribution in nodejs/undici#2807 - [@jeanp413](https://github.com/jeanp413) made their first contribution in nodejs/undici#2886 **Full Changelog**: nodejs/undici@v6.6.2...v6.7.0 ### [`v6.6.2`](https://github.com/nodejs/undici/releases/tag/v6.6.2) [Compare Source](nodejs/undici@v6.6.1...v6.6.2) #### What's Changed - fix: webidl.brandcheck non strict should throw by [@Uzlopak](https://github.com/Uzlopak) in nodejs/undici#2683 - fix: expose EventSource for nodejs by [@Uzlopak](https://github.com/Uzlopak) in nodejs/undici#2645 - test: more information from debug tests by [@Uzlopak](https://github.com/Uzlopak) in nodejs/undici#2695 - Fix broken test on linux by [@mcollina](https://github.com/mcollina) in nodejs/undici#2699 - fix: fix the linux patch by [@Uzlopak](https://github.com/Uzlopak) in nodejs/undici#2703 - test(wpt): mark timed out tests as 'failed' by [@rossilor95](https://github.com/rossilor95) in nodejs/undici#2644 - build(deps-dev): bump borp from 0.5.0 to 0.9.1 by [@dependabot](https://github.com/dependabot) in nodejs/undici#2702 - perf: use insertion sort algorithm by [@tsctx](https://github.com/tsctx) in nodejs/undici#2706 - fix: run node tests on merge by [@Uzlopak](https://github.com/Uzlopak) in nodejs/undici#2707 #### New Contributors - [@rossilor95](https://github.com/rossilor95) made their first contribution in nodejs/undici#2644 **Full Changelog**: nodejs/undici@v6.6.1...v6.6.2 ### [`v6.6.1`](https://github.com/nodejs/undici/releases/tag/v6.6.1) [Compare Source](nodejs/undici@v6.6.0...v6.6.1) #### ⚠️ Security Release ⚠️ Fixes: - [CVE-2024-24750, Backpressure request ignored in fetch()](GHSA-9f24-jqhm-jfcw) - [CVE-2024-24758 Proxy-Authorization header not cleared on cross-origin redirect in fetch](GHSA-3787-6prv-h9w3) #### What's Changed - fix: flaky debug test by [@Uzlopak](https://github.com/Uzlopak) in nodejs/undici#2687 - build(deps): bump github/codeql-action from 3.22.12 to 3.23.2 by [@dependabot](https://github.com/dependabot) in nodejs/undici#2688 - build(deps): bump actions/dependency-review-action from 3.1.0 to 4.0.0 by [@dependabot](https://github.com/dependabot) in nodejs/undici#2689 - fix: ci pipeline warnings by [@Uzlopak](https://github.com/Uzlopak) in nodejs/undici#2685 - perf: optimize Iterator by [@tsctx](https://github.com/tsctx) in nodejs/undici#2692 **Full Changelog**: nodejs/undici@v6.6.0...v6.6.1 ### [`v6.6.0`](https://github.com/nodejs/undici/releases/tag/v6.6.0) [Compare Source](nodejs/undici@v6.5.0...v6.6.0) #### What's Changed - add webSocket example by [@mertcanaltin](https://github.com/mertcanaltin) in nodejs/undici#2626 - chore: remove atomic-sleep as dev dependency by [@Uzlopak](https://github.com/Uzlopak) in nodejs/undici#2648 - chore: remove semver as dev dependency by [@Uzlopak](https://github.com/Uzlopak) in nodejs/undici#2646 - chore: remove table as dev dependency by [@Uzlopak](https://github.com/Uzlopak) in nodejs/undici#2649 - chore: remove delay as dev dependency by [@Uzlopak](https://github.com/Uzlopak) in nodejs/undici#2647 - chore: reduce noise in test-logs test/issue-2349.js by [@Uzlopak](https://github.com/Uzlopak) in nodejs/undici#2655 - chore: fix faketimer warning in test/request-timeout.js by [@Uzlopak](https://github.com/Uzlopak) in nodejs/undici#2656 - chore: reduce noise in test logs test/client-node-max-header-size.js by [@Uzlopak](https://github.com/Uzlopak) in nodejs/undici#2654 - refactor: use fromInnerResponse by [@tsctx](https://github.com/tsctx) in nodejs/undici#2635 - fix: support deflate raw responses by [@Uzlopak](https://github.com/Uzlopak) in nodejs/undici#2650 - Support building for externally shared js builtins by [@mochaaP](https://github.com/mochaaP) in nodejs/undici#2643 - fix: typo clampAndCoarsenConnectionTimingInfo by [@Uzlopak](https://github.com/Uzlopak) in nodejs/undici#2653 - chore: use 'node:'-prefix for requiring node core modules by [@Uzlopak](https://github.com/Uzlopak) in nodejs/undici#2662 - build(deps-dev): bump husky from 8.0.3 to 9.0.7 by [@dependabot](https://github.com/dependabot) in nodejs/undici#2667 - build(deps-dev): bump cronometro from 1.2.0 to 2.0.2 by [@dependabot](https://github.com/dependabot) in nodejs/undici#2668 - remove timers/promises import by [@KhafraDev](https://github.com/KhafraDev) in nodejs/undici#2665 - chore: fix various codesmells by [@Uzlopak](https://github.com/Uzlopak) in nodejs/undici#2669 - chore: remove this alias in agent.js by [@Uzlopak](https://github.com/Uzlopak) in nodejs/undici#2671 - chore: use optional chaining by [@Uzlopak](https://github.com/Uzlopak) in nodejs/undici#2666 - chore: small perf improvements by [@Uzlopak](https://github.com/Uzlopak) in nodejs/undici#2661 - implement spec changes from a while ago by [@KhafraDev](https://github.com/KhafraDev) in nodejs/undici#2676 - websocket: fix close when no closing code is received by [@KhafraDev](https://github.com/KhafraDev) in nodejs/undici#2680 - fix: make ci less flaky by [@Uzlopak](https://github.com/Uzlopak) in nodejs/undici#2684 #### New Contributors - [@mochaaP](https://github.com/mochaaP) made their first contribution in nodejs/undici#2643 **Full Changelog**: nodejs/undici@v6.5.0...v6.6.0 ### [`v6.5.0`](https://github.com/nodejs/undici/releases/tag/v6.5.0) [Compare Source](nodejs/undici@v6.4.0...v6.5.0) #### What's Changed - build(deps-dev): bump jsdom from 23.2.0 to 24.0.0 by [@dependabot](https://github.com/dependabot) in nodejs/undici#2632 - feat: Implement EventSource by [@Uzlopak](https://github.com/Uzlopak) in nodejs/undici#2608 - fix: readable body by [@ronag](https://github.com/ronag) in nodejs/undici#2642 **Full Changelog**: nodejs/undici@v6.4.0...v6.5.0 ### [`v6.4.0`](https://github.com/nodejs/undici/releases/tag/v6.4.0) [Compare Source](nodejs/undici@v6.3.0...v6.4.0) #### What's Changed - refactor: version cleanup by [@tsctx](https://github.com/tsctx) in nodejs/undici#2605 - cacheStorage: separate matchAll logic by [@KhafraDev](https://github.com/KhafraDev) in nodejs/undici#2599 - cleanup index by [@KhafraDev](https://github.com/KhafraDev) in nodejs/undici#2598 - feat: port `balanced-pool`, `ca-fingerprint`, `client-abort` tests to `node:test` by [@sosukesuzuki](https://github.com/sosukesuzuki) in nodejs/undici#2584 - ci: unpin nodejs workflow version by [@dominykas](https://github.com/dominykas) in nodejs/undici#2434 - test([#2600](nodejs/undici#2600)): Flaky debug test by [@metcoder95](https://github.com/metcoder95) in nodejs/undici#2607 - fix: h2 hang issue with empty body by [@timursevimli](https://github.com/timursevimli) in nodejs/undici#2601 - Fix tests for Node.js v21 by [@sosukesuzuki](https://github.com/sosukesuzuki) in nodejs/undici#2609 - perf(cache): avoid Request and Response initialization by [@tsctx](https://github.com/tsctx) in nodejs/undici#2610 - Add more libraries to benchmarks by [@mcollina](https://github.com/mcollina) in nodejs/undici#2614 - feat: port `client-connect`, `client-dispatch`, `client-errors` test to `node:test` by [@sosukesuzuki](https://github.com/sosukesuzuki) in nodejs/undici#2591 - exit with 1 if WPT runner has unexpected errors by [@KhafraDev](https://github.com/KhafraDev) in nodejs/undici#2621 - Fix tests for Node.js v20.11.0 by [@mcollina](https://github.com/mcollina) in nodejs/undici#2618 - fix(mock-agent): split set-cookie by [@tsctx](https://github.com/tsctx) in nodejs/undici#2619 - feat: implement throwOnMaxRedirect option for RedirectHandler by [@mertcanaltin](https://github.com/mertcanaltin) in nodejs/undici#2563 - test: fix flaky debug test by [@metcoder95](https://github.com/metcoder95) in nodejs/undici#2613 - fix: hide statusOutput if empty in handleRunnerCompletion by [@Uzlopak](https://github.com/Uzlopak) in nodejs/undici#2624 - docs: Fix typo in Debug.md by [@Skn0tt](https://github.com/Skn0tt) in nodejs/undici#2625 - fix(cache): set AbortSignal by [@tsctx](https://github.com/tsctx) in nodejs/undici#2612 - Use correct http Agent for node-fetch, axios, got and request by [@mcollina](https://github.com/mcollina) in nodejs/undici#2629 #### New Contributors - [@timursevimli](https://github.com/timursevimli) made their first contribution in nodejs/undici#2601 - [@mertcanaltin](https://github.com/mertcanaltin) made their first contribution in nodejs/undici#2563 - [@Skn0tt](https://github.com/Skn0tt) made their first contribution in nodejs/undici#2625 **Full Changelog**: nodejs/undici@v6.3.0...v6.4.0 ### [`v6.3.0`](https://github.com/nodejs/undici/releases/tag/v6.3.0) [Compare Source](nodejs/undici@v6.2.1...v6.3.0) #### What's Changed - Clear all timeout on destroy and close by [@mcollina](https://github.com/mcollina) in nodejs/undici#2535 - ConnectOptions should include 'origin' field by [@dvoytenko](https://github.com/dvoytenko) in nodejs/undici#2532 - perf: avoid toLowerCase call by [@tsctx](https://github.com/tsctx) in nodejs/undici#2537 - revert [`a1a8136`](nodejs/undici@a1a8136) by [@KhafraDev](https://github.com/KhafraDev) in nodejs/undici#2539 - docs: add Util to sidebar by [@tsctx](https://github.com/tsctx) in nodejs/undici#2529 - fix: call explicitly unregister by [@tsctx](https://github.com/tsctx) in nodejs/undici#2534 - fix: check the content-type of invalid formData by [@tsctx](https://github.com/tsctx) in nodejs/undici#2541 - Add request examples. by [@autopulated](https://github.com/autopulated) in nodejs/undici#2380 - fix(HTTP/2): handle consumption of aborted request by [@metcoder95](https://github.com/metcoder95) in nodejs/undici#2387 - chore: update tst test by [@tsctx](https://github.com/tsctx) in nodejs/undici#2538 - fix(fetch): do not abort fetch on redirect by [@angelyan](https://github.com/angelyan) in nodejs/undici#2545 - drop verifyVersion in scripts by [@KhafraDev](https://github.com/KhafraDev) in nodejs/undici#2549 - types: remove unused Client and Pool types by [@RafaelGSS](https://github.com/RafaelGSS) in nodejs/undici#2557 - lib: fix Host header when CONNECT ProxyAgent by [@RafaelGSS](https://github.com/RafaelGSS) in nodejs/undici#2556 - feat: port cookies tests to node runner by [@pmarchini](https://github.com/pmarchini) in nodejs/undici#2547 - feat: port webidl tests to node test runner by [@ilteoood](https://github.com/ilteoood) in nodejs/undici#2554 - perf: Improve percentDecode by [@tsctx](https://github.com/tsctx) in nodejs/undici#2562 - Fix parseHashWithOptions regex by [@flapenna](https://github.com/flapenna) in nodejs/undici#2561 - feat: port diagnostic-channel tests to node test runner by [@ilteoood](https://github.com/ilteoood) in nodejs/undici#2559 - feat: port websocket tests to node test runner by [@ilteoood](https://github.com/ilteoood) in nodejs/undici#2553 - build(deps-dev): bump tsd from 0.29.0 to 0.30.1 by [@dependabot](https://github.com/dependabot) in nodejs/undici#2551 - build(deps): bump actions/setup-node from 4.0.0 to 4.0.1 by [@dependabot](https://github.com/dependabot) in nodejs/undici#2572 - build(deps): bump github/codeql-action from 2.22.5 to 3.22.12 by [@dependabot](https://github.com/dependabot) in nodejs/undici#2574 - Update `@matteo.collina/tspl` to 0.1.1 by [@sosukesuzuki](https://github.com/sosukesuzuki) in nodejs/undici#2576 - mark wpt as failing by [@KhafraDev](https://github.com/KhafraDev) in nodejs/undici#2581 - feat: port `abort-controller.js` tests to `node:test` runner by [@sosukesuzuki](https://github.com/sosukesuzuki) in nodejs/undici#2564 - fix data url test by [@KhafraDev](https://github.com/KhafraDev) in nodejs/undici#2580 - feat: port `async_hooks.js` tests to `node:test` runner by [@sosukesuzuki](https://github.com/sosukesuzuki) in nodejs/undici#2568 - feat: port `agent.js` tests to `node:test` runner by [@sosukesuzuki](https://github.com/sosukesuzuki) in nodejs/undici#2566 - feat: port `abort-event-emitter.js` tests to `node:test` runnner by [@sosukesuzuki](https://github.com/sosukesuzuki) in nodejs/undici#2565 - feat: port first half of fetch tests to node test runner by [@anurag-roy](https://github.com/anurag-roy) in nodejs/undici#2569 - perf: bypass method validation by [@tsctx](https://github.com/tsctx) in nodejs/undici#2583 - fetch: warn when using patch method by [@KhafraDev](https://github.com/KhafraDev) in nodejs/undici#2577 - feat: port `autoselectfamily.js` tests to `node:test` runner by [@sosukesuzuki](https://github.com/sosukesuzuki) in nodejs/undici#2570 - feat: port remaining fetch tests to node test runner by [@anurag-roy](https://github.com/anurag-roy) in nodejs/undici#2587 - fix: use isArrayBuffer instead of isAnyArrayBuffer by [@tsctx](https://github.com/tsctx) in nodejs/undici#2586 - Feat/migrate tests to node runner by [@pmarchini](https://github.com/pmarchini) in nodejs/undici#2593 - abort request with reason if one is provided by [@KhafraDev](https://github.com/KhafraDev) in nodejs/undici#2592 - feat: port tst test to node test runner by [@tsctx](https://github.com/tsctx) in nodejs/undici#2595 - feat([#2191](nodejs/undici#2191)): Add support for `NODE_DEBUG` by [@metcoder95](https://github.com/metcoder95) in nodejs/undici#2585 - cacheStorage: fix bugs make wpts pass by [@KhafraDev](https://github.com/KhafraDev) in nodejs/undici#2596 - fix: non-object error in abort throws bad error by [@atlowChemi](https://github.com/atlowChemi) in nodejs/undici#2597 - fix: add test helper for closing server as promise by [@sosukesuzuki](https://github.com/sosukesuzuki) in nodejs/undici#2604 #### New Contributors - [@dvoytenko](https://github.com/dvoytenko) made their first contribution in nodejs/undici#2532 - [@autopulated](https://github.com/autopulated) made their first contribution in nodejs/undici#2380 - [@angelyan](https://github.com/angelyan) made their first contribution in nodejs/undici#2545 - [@pmarchini](https://github.com/pmarchini) made their first contribution in nodejs/undici#2547 - [@ilteoood](https://github.com/ilteoood) made their first contribution in nodejs/undici#2554 - [@flapenna](https://github.com/flapenna) made their first contribution in nodejs/undici#2561 - [@sosukesuzuki](https://github.com/sosukesuzuki) made their first contribution in nodejs/undici#2576 - [@anurag-roy](https://github.com/anurag-roy) made their first contribution in nodejs/undici#2569 **Full Changelog**: nodejs/undici@v6.2.1...v6.3.0 ### [`v6.2.1`](https://github.com/nodejs/undici/releases/tag/v6.2.1) [Compare Source](nodejs/undici@v6.2.0...v6.2.1) #### What's Changed - perf: use tree by [@tsctx](https://github.com/tsctx) in nodejs/undici#2528 - chore: reduce dependencies by [@tsctx](https://github.com/tsctx) in nodejs/undici#2533 - Remove timers in agent.js by [@mcollina](https://github.com/mcollina) in nodejs/undici#2536 **Full Changelog**: nodejs/undici@v6.2.0...v6.2.1 ### [`v6.2.0`](https://github.com/nodejs/undici/releases/tag/v6.2.0) [Compare Source](nodejs/undici@v6.1.0...v6.2.0) #### What's Changed - Remove FinalizationRegistry from Agent by [@mcollina](https://github.com/mcollina) in nodejs/undici#2530 **Full Changelog**: nodejs/undici@v6.1.0...v6.2.0 ### [`v6.1.0`](https://github.com/nodejs/undici/releases/tag/v6.1.0) [Compare Source](nodejs/undici@v6.0.1...v6.1.0) #### What's Changed - fix: more sensible stack trace from dump error by [@ronag](https://github.com/ronag) in nodejs/undici#2503 - refactor: remove some node compat by [@ronag](https://github.com/ronag) in nodejs/undici#2502 - refactor: version cleanup by [@tsctx](https://github.com/tsctx) in nodejs/undici#2507 - perf(fetch): Improve fetch of detaurl by [@tsctx](https://github.com/tsctx) in nodejs/undici#2479 - feat: expose parseHeader by [@ronag](https://github.com/ronag) in nodejs/undici#2511 - perf(fetch): optimize call `dispatch` by [@tsctx](https://github.com/tsctx) in nodejs/undici#2493 - perf(util/parseHeaders): If the header name is buffer by [@tsctx](https://github.com/tsctx) in nodejs/undici#2501 - perf: twice faster method check by [@tsctx](https://github.com/tsctx) in nodejs/undici#2495 - refactor: remove Error.captureStackTrace by [@tsctx](https://github.com/tsctx) in nodejs/undici#2509 - perf: Improve processHeader by [@tsctx](https://github.com/tsctx) in nodejs/undici#2513 - perf: reduce `String#toLowerCase` call by [@tsctx](https://github.com/tsctx) in nodejs/undici#2516 - perf: optimize consumeEnd by [@tsctx](https://github.com/tsctx) in nodejs/undici#2510 - perf: reduce tst built time by [@tsctx](https://github.com/tsctx) in nodejs/undici#2517 - feat: allow customization of build environment by [@khardix](https://github.com/khardix) in nodejs/undici#2403 - fix: clear cache by [@tsctx](https://github.com/tsctx) in nodejs/undici#2519 - feat: Add resource timing entries for connection, request and response by [@ToshB](https://github.com/ToshB) in nodejs/undici#2481 - Call fg.unregister() after a dispatcher is done, adds UNDICI_NO_FG to… by [@mcollina](https://github.com/mcollina) in nodejs/undici#2527 - feat: expose headerNameToString by [@tsctx](https://github.com/tsctx) in nodejs/undici#2525 #### New Contributors - [@khardix](https://github.com/khardix) made their first contribution in nodejs/undici#2403 **Full Changelog**: nodejs/undici@v6.0.1...v6.1.0 ### [`v6.0.1`](https://github.com/nodejs/undici/releases/tag/v6.0.1) [Compare Source](nodejs/undici@v6.0.0...v6.0.1) #### What's Changed - fix: stream error timings by [@ronag](https://github.com/ronag) in nodejs/undici#2497 **Full Changelog**: nodejs/undici@v6.0.0...v6.0.1 ### [`v6.0.0`](https://github.com/nodejs/undici/releases/tag/v6.0.0) [Compare Source](nodejs/undici@v5.28.3...v6.0.0) #### What's Changed - 16 eol by [@ronag](https://github.com/ronag) in nodejs/undici#2480 - update spec & wpts by [@KhafraDev](https://github.com/KhafraDev) in nodejs/undici#2482 - version cleanup by [@KhafraDev](https://github.com/KhafraDev) in nodejs/undici#2483 - perf: avoid Response initialization by [@tsctx](https://github.com/tsctx) in nodejs/undici#2489 - perf: optimize `parseHeaders` by [@tsctx](https://github.com/tsctx) in nodejs/undici#2492 - chore: fix typo by [@tsctx](https://github.com/tsctx) in nodejs/undici#2490 - feat: print attempted addresses on ConnectTimeoutError by [@fengmk2](https://github.com/fengmk2) in nodejs/undici#2494 - Expose HTTP errors that are not meant to be retried by [@MzUgM](https://github.com/MzUgM) in nodejs/undici#2496 **Full Changelog**: nodejs/undici@v5.28.2...v6.0.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Reviewed-on: https://gitea.vylpes.xyz/RabbitLabs/vylbot-app/pulls/416 Co-authored-by: Renovate Bot <renovate@vylpes.com> Co-committed-by: Renovate Bot <renovate@vylpes.com>

update spec & wpts

ad01659

restore fetch error debug time

KhafraDev marked this pull request as draft December 1, 2023 04:14

github-advanced-security bot found potential problems Dec 1, 2023

View reviewed changes

test/wpt/tests/fetch/private-network-access/resources/opener.html Dismissed Show dismissed Hide dismissed

KhafraDev added 2 commits November 30, 2023 23:29

fix some test failures for others!!

b2d5e65

fix some test failures for others!!

6a25b4a

KhafraDev commented Dec 1, 2023

View reviewed changes

lib/fetch/dataURL.js Show resolved Hide resolved

This comment was marked as outdated.

Sign in to view

KhafraDev added 3 commits December 1, 2023 13:34

fix most remaining failures

214785a

fix remaining WPT fail

1ef8cfc

fix fetching blob

b5dcb40

KhafraDev mentioned this pull request Dec 1, 2023

chore: less async await #2464

Closed

7 tasks

mark websocket WPTs as failing

a4c9af3

KhafraDev marked this pull request as ready for review December 1, 2023 19:22

KhafraDev added the semver-major Features or fixes that will be included in the next semver major release label Dec 1, 2023

KhafraDev requested a review from ronag December 1, 2023 19:23

ronag approved these changes Dec 1, 2023

View reviewed changes

KhafraDev merged commit af9aaea into nodejs:main Dec 1, 2023
13 of 15 checks passed

KhafraDev deleted the update-spec branch December 1, 2023 20:31

KhafraDev mentioned this pull request Jan 4, 2024

deps: update undici to 6.2.1 nodejs/node#51278

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

update spec & wpts #2482

update spec & wpts #2482

KhafraDev commented Dec 1, 2023 •

edited

Loading

codecov-commenter commented Dec 1, 2023 •

edited

Loading

debadree25 commented Dec 1, 2023

KhafraDev commented Dec 1, 2023

This comment was marked as outdated.

KhafraDev commented Dec 1, 2023

ronag left a comment

ronag commented Dec 1, 2023

KhafraDev commented Dec 1, 2023 •

edited

Loading

ronag commented Dec 1, 2023

KhafraDev commented Dec 1, 2023 •

edited

Loading

KhafraDev commented Dec 1, 2023

update spec & wpts #2482

update spec & wpts #2482

Conversation

KhafraDev commented Dec 1, 2023 • edited Loading

codecov-commenter commented Dec 1, 2023 • edited Loading

Codecov Report

debadree25 commented Dec 1, 2023

KhafraDev commented Dec 1, 2023

This comment was marked as outdated.

KhafraDev commented Dec 1, 2023

ronag left a comment

Choose a reason for hiding this comment

ronag commented Dec 1, 2023

KhafraDev commented Dec 1, 2023 • edited Loading

ronag commented Dec 1, 2023

KhafraDev commented Dec 1, 2023 • edited Loading

KhafraDev commented Dec 1, 2023

KhafraDev commented Dec 1, 2023 •

edited

Loading

codecov-commenter commented Dec 1, 2023 •

edited

Loading

KhafraDev commented Dec 1, 2023 •

edited

Loading

KhafraDev commented Dec 1, 2023 •

edited

Loading