-
Notifications
You must be signed in to change notification settings - Fork 539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Is there a plan to add options for setting HTTP headers on EventSource? #3115
Comments
Your opinion on this request? |
we should add it |
I added a dispatcher in EventSource, how should I manage it, do we have certain rules? @Uzlopak @KhafraDev |
The same way fetch and websocket implement it https://github.com/nodejs/undici?tab=readme-ov-file#undicifetchinput-init-promise |
I wonder if that's a good method |
No, dispatcher should be added as an optional property in the eventsource options (second parameter) and I'm not sure if we need to add custom headers since it can be done with Agent. Also there is no step 11 that adds custom headers in the spec so all of those changes to comments should be undone. |
Discussed in #3112
Originally posted by zbinlin April 13, 2024
Likes Websocket, we can adds a
dispatcher
option toEventSource
constructor.The text was updated successfully, but these errors were encountered: