Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

h2 doesn't follow hook pause strictly #3027

Closed
ronag opened this issue Mar 31, 2024 · 3 comments
Closed

h2 doesn't follow hook pause strictly #3027

ronag opened this issue Mar 31, 2024 · 3 comments
Labels
bug Something isn't working H2 Pull requests or issues related to HTTP/2

Comments

@ronag
Copy link
Member

ronag commented Mar 31, 2024

If any hook returns false no other hook should be called until resume has been invoked. I don't believe this is strictly the case atm.
@ronag ronag added the bug Something isn't working label Mar 31, 2024
@ronag
Copy link
Member Author

ronag commented Mar 31, 2024

@metcoder95

@metcoder95
Copy link
Member

Do you have a reproduction I can use or a reference on which they happened?

@metcoder95 metcoder95 added the H2 Pull requests or issues related to HTTP/2 label Apr 1, 2024
@ronag
Copy link
Member Author

ronag commented Apr 1, 2024

I misread the code. Sorry.

@ronag ronag closed this as completed Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working H2 Pull requests or issues related to HTTP/2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ronag @metcoder95