Reduce Buffer operations in EventSource #2630
Labels
enhancement
New feature or request
eventsource
Pull requests or issues related to EventSource and its standard
In the EventSourceStream code of the initial EventSource implementation, alot of Buffer Operations are used to process the incoming Stream. The Buffer operations are concentrated in the
_transform
andparseLine
method of theEventSourceStream
.I am sure, we can reduce the overhead of the buffer operations by using some simple integer variables, marking start and end of the Buffer we want to extract the subarray and then pass it accordingly
parseLine
method.Maybe the Buffer.concat operation to buffer the incoming chunks can be avoided. But be careful, as the incoming stream is containing utf8 code. So you have to concat the buffers at one point to avoid utf8 issues.
In the
parseLine
method the field and value are also processed via .subarray. Maybe first callingtoString('utf8')
and then processing it makes more sense? Anyhow, some benchmarking would be useful to make a informed decision.The text was updated successfully, but these errors were encountered: