-
Notifications
You must be signed in to change notification settings - Fork 579
/
Copy pathredirect-request.js
526 lines (398 loc) · 15.5 KB
/
redirect-request.js
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
'use strict'
const { tspl } = require('@matteo.collina/tspl')
const { test, after } = require('node:test')
const undici = require('..')
const {
startRedirectingServer,
startRedirectingWithBodyServer,
startRedirectingChainServers,
startRedirectingWithoutLocationServer,
startRedirectingWithAuthorization,
startRedirectingWithCookie,
startRedirectingWithQueryParams
} = require('./utils/redirecting-servers')
const { createReadable, createReadableStream } = require('./utils/stream')
const redirect = undici.interceptors.redirect
for (const factory of [
(server, opts) => new undici.Agent(opts).compose(redirect({ maxRedirections: opts?.maxRedirections })),
(server, opts) => new undici.Pool(`http://${server}`, opts).compose(redirect({ maxRedirections: opts?.maxRedirections })),
(server, opts) => new undici.Client(`http://${server}`, opts).compose(redirect({ maxRedirections: opts?.maxRedirections }))
]) {
const request = (t, server, opts, ...args) => {
const dispatcher = factory(server, opts)
after(() => dispatcher.close())
return undici.request(args[0], { ...args[1], dispatcher }, args[2])
}
test('should always have a history with the final URL even if no redirections were followed', async t => {
t = tspl(t, { plan: 4 })
const server = await startRedirectingServer()
const { statusCode, headers, body: bodyStream, context: { history } } = await request(t, server, undefined, `http://${server}/200?key=value`, {
maxRedirections: 10
})
const body = await bodyStream.text()
t.strictEqual(statusCode, 200)
t.ok(!headers.location)
t.deepStrictEqual(history.map(x => x.toString()), [`http://${server}/200?key=value`])
t.strictEqual(body, `GET /5 key=value :: host@${server} connection@keep-alive`)
await t.completed
})
test('should not follow redirection by default if not using RedirectAgent', async t => {
t = tspl(t, { plan: 3 })
const server = await startRedirectingServer()
const { statusCode, headers, body: bodyStream } = await request(t, server, undefined, `http://${server}`)
const body = await bodyStream.text()
t.strictEqual(statusCode, 302)
t.strictEqual(headers.location, `http://${server}/302/1`)
t.strictEqual(body.length, 0)
await t.completed
})
test('should follow redirection after a HTTP 300', async t => {
t = tspl(t, { plan: 4 })
const server = await startRedirectingServer()
const { statusCode, headers, body: bodyStream, context: { history } } = await request(t, server, undefined, `http://${server}/300?key=value`, {
maxRedirections: 10
})
const body = await bodyStream.text()
t.strictEqual(statusCode, 200)
t.ok(!headers.location)
t.deepStrictEqual(history.map(x => x.toString()), [
`http://${server}/300?key=value`,
`http://${server}/300/1?key=value`,
`http://${server}/300/2?key=value`,
`http://${server}/300/3?key=value`,
`http://${server}/300/4?key=value`,
`http://${server}/300/5?key=value`
])
t.strictEqual(body, `GET /5 key=value :: host@${server} connection@keep-alive`)
await t.completed
})
test('should follow redirection after a HTTP 300 default', async t => {
t = tspl(t, { plan: 4 })
const server = await startRedirectingServer()
const { statusCode, headers, body: bodyStream, context: { history } } = await request(t, server, undefined, `http://${server}/300?key=value`, { maxRedirections: 10 })
const body = await bodyStream.text()
t.strictEqual(statusCode, 200)
t.ok(!headers.location)
t.deepStrictEqual(history.map(x => x.toString()), [
`http://${server}/300?key=value`,
`http://${server}/300/1?key=value`,
`http://${server}/300/2?key=value`,
`http://${server}/300/3?key=value`,
`http://${server}/300/4?key=value`,
`http://${server}/300/5?key=value`
])
t.strictEqual(body, `GET /5 key=value :: host@${server} connection@keep-alive`)
await t.completed
})
test('should follow redirection after a HTTP 301', async t => {
t = tspl(t, { plan: 3 })
const server = await startRedirectingServer()
const { statusCode, headers, body: bodyStream } = await request(t, server, undefined, `http://${server}/301`, {
method: 'POST',
body: 'REQUEST',
maxRedirections: 10
})
const body = await bodyStream.text()
t.strictEqual(statusCode, 200)
t.ok(!headers.location)
t.strictEqual(body, `POST /5 :: host@${server} connection@keep-alive content-length@7 :: REQUEST`)
})
test('should follow redirection after a HTTP 302', async t => {
t = tspl(t, { plan: 3 })
const server = await startRedirectingServer()
const { statusCode, headers, body: bodyStream } = await request(t, server, undefined, `http://${server}/302`, {
method: 'PUT',
body: Buffer.from('REQUEST'),
maxRedirections: 10
})
const body = await bodyStream.text()
t.strictEqual(statusCode, 200)
t.ok(!headers.location)
t.strictEqual(body, `PUT /5 :: host@${server} connection@keep-alive content-length@7 :: REQUEST`)
})
test('should follow redirection after a HTTP 303 changing method to GET', async t => {
t = tspl(t, { plan: 3 })
const server = await startRedirectingServer()
const { statusCode, headers, body: bodyStream } = await request(t, server, undefined, `http://${server}/303`, {
method: 'PATCH',
body: 'REQUEST',
maxRedirections: 10
})
const body = await bodyStream.text()
t.strictEqual(statusCode, 200)
t.ok(!headers.location)
t.strictEqual(body, `GET /5 :: host@${server} connection@keep-alive`)
await t.completed
})
test('should remove Host and request body related headers when following HTTP 303 (array)', async t => {
t = tspl(t, { plan: 3 })
const server = await startRedirectingServer()
const { statusCode, headers, body: bodyStream } = await request(t, server, undefined, `http://${server}/303`, {
method: 'PATCH',
headers: [
'Content-Encoding',
'gzip',
'X-Foo1',
'1',
'X-Foo2',
'2',
'Content-Type',
'application/json',
'X-Foo3',
'3',
'Host',
'localhost',
'X-Bar',
'4'
],
maxRedirections: 10
})
const body = await bodyStream.text()
t.strictEqual(statusCode, 200)
t.ok(!headers.location)
t.strictEqual(body, `GET /5 :: host@${server} connection@keep-alive x-foo1@1 x-foo2@2 x-foo3@3 x-bar@4`)
await t.completed
})
test('should remove Host and request body related headers when following HTTP 303 (object)', async t => {
t = tspl(t, { plan: 3 })
const server = await startRedirectingServer()
const { statusCode, headers, body: bodyStream } = await request(t, server, undefined, `http://${server}/303`, {
method: 'PATCH',
headers: {
'Content-Encoding': 'gzip',
'X-Foo1': '1',
'X-Foo2': '2',
'Content-Type': 'application/json',
'X-Foo3': '3',
Host: 'localhost',
'X-Bar': '4'
},
maxRedirections: 10
})
const body = await bodyStream.text()
t.strictEqual(statusCode, 200)
t.ok(!headers.location)
t.strictEqual(body, `GET /5 :: host@${server} connection@keep-alive x-foo1@1 x-foo2@2 x-foo3@3 x-bar@4`)
await t.completed
})
test('should follow redirection after a HTTP 307', async t => {
t = tspl(t, { plan: 3 })
const server = await startRedirectingServer()
const { statusCode, headers, body: bodyStream } = await request(t, server, undefined, `http://${server}/307`, {
method: 'DELETE',
maxRedirections: 10
})
const body = await bodyStream.text()
t.strictEqual(statusCode, 200)
t.ok(!headers.location)
t.strictEqual(body, `DELETE /5 :: host@${server} connection@keep-alive`)
await t.completed
})
test('should follow redirection after a HTTP 308', async t => {
t = tspl(t, { plan: 3 })
const server = await startRedirectingServer()
const { statusCode, headers, body: bodyStream } = await request(t, server, undefined, `http://${server}/308`, {
method: 'OPTIONS',
maxRedirections: 10
})
const body = await bodyStream.text()
t.strictEqual(statusCode, 200)
t.ok(!headers.location)
t.strictEqual(body, `OPTIONS /5 :: host@${server} connection@keep-alive`)
await t.completed
})
test('should ignore HTTP 3xx response bodies', async t => {
t = tspl(t, { plan: 4 })
const server = await startRedirectingWithBodyServer()
const { statusCode, headers, body: bodyStream, context: { history } } = await request(t, server, undefined, `http://${server}/`, {
maxRedirections: 10
})
const body = await bodyStream.text()
t.strictEqual(statusCode, 200)
t.ok(!headers.location)
t.deepStrictEqual(history.map(x => x.toString()), [`http://${server}/`, `http://${server}/end`])
t.strictEqual(body, 'FINAL')
await t.completed
})
test('should ignore query after redirection', async t => {
t = tspl(t, { plan: 3 })
const server = await startRedirectingWithQueryParams()
const { statusCode, headers, context: { history } } = await request(t, server, undefined, `http://${server}/`, {
maxRedirections: 10,
query: { param1: 'first' }
})
t.strictEqual(statusCode, 200)
t.ok(!headers.location)
t.deepStrictEqual(history.map(x => x.toString()), [`http://${server}/`, `http://${server}/?param2=second`])
await t.completed
})
test('should follow a redirect chain up to the allowed number of times', async t => {
t = tspl(t, { plan: 4 })
const server = await startRedirectingServer()
const { statusCode, headers, body: bodyStream, context: { history } } = await request(t, server, undefined, `http://${server}/300`, {
maxRedirections: 2
})
const body = await bodyStream.text()
t.strictEqual(statusCode, 300)
t.strictEqual(headers.location, `http://${server}/300/3`)
t.deepStrictEqual(history.map(x => x.toString()), [`http://${server}/300`, `http://${server}/300/1`, `http://${server}/300/2`])
t.strictEqual(body.length, 0)
await t.completed
})
test('should follow a redirect chain up to the allowed number of times for redirectionLimitReached', async t => {
t = tspl(t, { plan: 1 })
const server = await startRedirectingServer()
try {
await request(t, server, undefined, `http://${server}/300`, {
maxRedirections: 2,
throwOnMaxRedirect: true
})
} catch (error) {
if (error.message.startsWith('max redirects')) {
t.ok(true, 'Max redirects handled correctly')
} else {
t.fail(`Unexpected error: ${error.message}`)
}
}
await t.completed
})
test('when a Location response header is NOT present', async t => {
t = tspl(t, { plan: 6 * 3 })
const redirectCodes = [300, 301, 302, 303, 307, 308]
const server = await startRedirectingWithoutLocationServer()
for (const code of redirectCodes) {
const { statusCode, headers, body: bodyStream } = await request(t, server, undefined, `http://${server}/${code}`, {
maxRedirections: 10
})
const body = await bodyStream.text()
t.strictEqual(statusCode, code)
t.ok(!headers.location)
t.strictEqual(body.length, 0)
}
await t.completed
})
test('should not allow invalid maxRedirections arguments', async t => {
t = tspl(t, { plan: 1 })
try {
await request(t, 'localhost', undefined, 'http://localhost', {
method: 'GET',
maxRedirections: 'INVALID'
})
t.fail('Did not throw')
} catch (err) {
t.strictEqual(err.message, 'maxRedirections must be a positive number')
}
await t.completed
})
test('should not allow invalid maxRedirections arguments default', async t => {
t = tspl(t, { plan: 1 })
try {
await request(t, 'localhost', undefined, 'http://localhost', {
method: 'GET',
maxRedirections: 'INVALID'
})
t.fail('Did not throw')
} catch (err) {
t.strictEqual(err.message, 'maxRedirections must be a positive number')
}
await t.completed
})
test('should not follow redirects when using ReadableStream request bodies', async t => {
t = tspl(t, { plan: 3 })
const server = await startRedirectingServer()
const { statusCode, headers, body: bodyStream } = await request(t, server, undefined, `http://${server}/301`, {
method: 'POST',
body: createReadableStream('REQUEST'),
maxRedirections: 10
})
const body = await bodyStream.text()
t.strictEqual(statusCode, 301)
t.strictEqual(headers.location, `http://${server}/301/2`)
t.strictEqual(body.length, 0)
await t.completed
})
test('should not follow redirects when using Readable request bodies', async t => {
t = tspl(t, { plan: 3 })
const server = await startRedirectingServer()
const { statusCode, headers, body: bodyStream } = await request(t, server, undefined, `http://${server}/301`, {
method: 'POST',
body: createReadable('REQUEST'),
maxRedirections: 10
})
const body = await bodyStream.text()
t.strictEqual(statusCode, 301)
t.strictEqual(headers.location, `http://${server}/301/1`)
t.strictEqual(body.length, 0)
await t.completed
})
}
test('should follow redirections when going cross origin', async t => {
t = tspl(t, { plan: 4 })
const [server1, server2, server3] = await startRedirectingChainServers()
const { statusCode, headers, body: bodyStream, context: { history } } = await undici.request(`http://${server1}`, {
method: 'POST',
dispatcher: new undici.Agent({}).compose(redirect({ maxRedirections: 10 }))
})
const body = await bodyStream.text()
t.strictEqual(statusCode, 200)
t.ok(!headers.location)
t.deepStrictEqual(history.map(x => x.toString()), [
`http://${server1}/`,
`http://${server2}/`,
`http://${server3}/`,
`http://${server2}/end`,
`http://${server3}/end`,
`http://${server1}/end`
])
t.strictEqual(body, 'POST')
await t.completed
})
test('should handle errors (callback)', async t => {
t = tspl(t, { plan: 1 })
undici.request(
'http://localhost:0',
{
dispatcher: new undici.Agent({}).compose(redirect({ maxRedirections: 10 }))
},
error => {
t.match(error.code, /EADDRNOTAVAIL|ECONNREFUSED/)
}
)
await t.completed
})
test('should handle errors (promise)', async t => {
t = tspl(t, { plan: 1 })
try {
await undici.request('http://localhost:0', { dispatcher: new undici.Agent({}).compose(redirect({ maxRedirections: 10 })) })
t.fail('Did not throw')
} catch (error) {
t.match(error.code, /EADDRNOTAVAIL|ECONNREFUSED/)
}
await t.completed
})
test('removes authorization header on third party origin', async t => {
t = tspl(t, { plan: 1 })
const [server1] = await startRedirectingWithAuthorization('secret')
const { body: bodyStream } = await undici.request(`http://${server1}`, {
dispatcher: new undici.Agent({}).compose(redirect({ maxRedirections: 10 })),
headers: {
authorization: 'secret'
}
})
const body = await bodyStream.text()
t.strictEqual(body, '')
await t.completed
})
test('removes cookie header on third party origin', async t => {
t = tspl(t, { plan: 1 })
const [server1] = await startRedirectingWithCookie('a=b')
const { body: bodyStream } = await undici.request(`http://${server1}`, {
dispatcher: new undici.Agent({}).compose(redirect({ maxRedirections: 10 })),
headers: {
cookie: 'a=b'
}
})
const body = await bodyStream.text()
t.strictEqual(body, '')
await t.completed
})