Merged
Conversation
cclauss
reviewed
Sep 4, 2022
Co-authored-by: Christian Clauss <cclauss@me.com>
cclauss
requested changes
Sep 5, 2022
| <testcase name="test-accessor-properties" time="0.001711" classname="parallel"> | ||
| <failure type="1" message="fail (1)"> | ||
| --- | ||
| duration_ms: 1.711 |
Member
Author
There was a problem hiding this comment.
this includes raw TAP - so it is expected to be milliseconds, but jUnit time attribute is expected as seconds
Collaborator
There was a problem hiding this comment.
Yes. No wonder that everyone is confused.
| <testcase name="test_runner_describe_it" time="0.004758" classname="message"> | ||
| <failure type="1" message="fail (1)"> | ||
| --- | ||
| duration_ms: 4.758 |
Collaborator
|
Changed lines |
aduh95
approved these changes
Sep 6, 2022
Contributor
aduh95
left a comment
aduh95
left a comment
There was a problem hiding this comment.
I don't know enough about JUnit time attribute, but I trust that it's indeed in seconds, and the code changes LGTM.
Member
Author
|
I think only @cclauss can merge this? |
benjamingr
approved these changes
Sep 6, 2022
Member
|
Members of @nodejs/build are also admins of this repo |
Member
|
added some comments about this @ nodejs/node#44450 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this fixes the same historical mistake from nodejs/node#44450