Skip to content

Add Travis-CI setup #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 7, 2019
Merged

Add Travis-CI setup #20

merged 3 commits into from
Sep 7, 2019

Conversation

nschonni
Copy link
Member

@nschonni nschonni commented Sep 5, 2019

Fixes #19

@nschonni
Copy link
Member Author

nschonni commented Sep 5, 2019

Here is the CI status:

Submitted nodejs/node#29463 to fix the remaining error in the CI

@nschonni nschonni changed the title chore: npm upgrade for first-heading-level warning Add Travis-CI setup Sep 5, 2019
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM although I guess nodejs/node#29447 needs to land first.

@nschonni
Copy link
Member Author

nschonni commented Sep 5, 2019

This could probably land before the other one, but it will just be red till the other PR.

PS: Should I add the Travis badge to the readme?

@Trott
Copy link
Member

Trott commented Sep 6, 2019

PS: Should I add the Travis badge to the readme?

That would be 👍 by me.

Minor readme formatting
@nschonni
Copy link
Member Author

nschonni commented Sep 6, 2019

Done

@nschonni
Copy link
Member Author

nschonni commented Sep 7, 2019

@Trott I think this should be good to land now that the upstream PR has landed.
Do you have the ability to turn on the Travis hook after?

@Trott Trott merged commit fb48277 into nodejs:master Sep 7, 2019
@Trott
Copy link
Member

Trott commented Sep 7, 2019

OK, it's enabled.

@nschonni nschonni deleted the travis-ci branch September 7, 2019 21:52
@XhmikosR
Copy link
Contributor

@nschonni I was looking at this and I don't understand, why is the tmp folder added in git?

@XhmikosR
Copy link
Contributor

It seems like someone tried to add a submodule but then changed their mind.

@XhmikosR XhmikosR mentioned this pull request Sep 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setup CI for testing changes
3 participants