-
-
Notifications
You must be signed in to change notification settings - Fork 24
Add Travis-CI setup #20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Here is the CI status:
Submitted nodejs/node#29463 to fix the remaining error in the CI |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM although I guess nodejs/node#29447 needs to land first.
This could probably land before the other one, but it will just be red till the other PR. PS: Should I add the Travis badge to the readme? |
That would be 👍 by me. |
Minor readme formatting
Done |
@Trott I think this should be good to land now that the upstream PR has landed. |
OK, it's enabled. |
@nschonni I was looking at this and I don't understand, why is the tmp folder added in git? |
It seems like someone tried to add a submodule but then changed their mind. |
Fixes #19