Remove requirement for bundler custom config (#489)

* feat: use buffer, events, process dependencies and require it

* fix: added missing process file for browserify bug workaround

* fix: patch code after use strict

Author: bergos

build/build.mjs

@@ -15,6 +15,7 @@ import { headers } from './headers.mjs'
 import { replacements } from './replacements.mjs'
 
 const baseMatcher = /^(?:lib|test)/
+const strictMatcher = /^(['"']use strict.+)/
 
 function highlightFile(file, color) {
   return `\x1b[${color}m${file.replace(process.cwd() + '/', '')}\x1b[0m`
@@ -101,7 +102,11 @@ async function processFiles(contents) {
 
       for (const footerKey of matchingHeaders) {
         for (const header of headers[footerKey]) {
-          content = header + content
+          if (content.match(strictMatcher)) {
+            content = content.replace(strictMatcher, `$&;${header}`)
+          } else {
+            content = header + content
+          }
         }
       }
     }

build/headers.mjs

@@ -1,3 +1,19 @@
+const bufferRequire = `
+  /* replacement start */
+
+  const { Buffer } = require('buffer')
+
+  /* replacement end */
+`
+
+const processRequire = `
+  /* replacement start */
+
+  const process = require('process')
+
+  /* replacement end */
+`
+
 const testPolyfills = `
   /* replacement start */
   const AbortController = globalThis.AbortController || require('abort-controller').AbortController;
@@ -16,6 +32,16 @@ const testPolyfills = `
 `
 
 export const headers = {
+  'lib/stream.js':
+    [bufferRequire],
+  'lib/internal/streams/(destroy|duplexify|end-of-stream|from|pipeline|readable|writable).js':
+    [processRequire],
+  'test/browser/test-stream-(big-packet|pipe-cleanup-pause|pipeline|readable-event|transform-constructor-set-methods|transform-split-objectmode|unshift-empty-chunk|unshift-read-race|writable-change-default-encoding|writable-constructor-set-methods|writable-decoded-encoding|writev).js':
+    [bufferRequire],
+  'test/browser/test-stream2-(base64-single-char-read-end|compatibility|large-read-stall|pipe-error-handling|readable-empty-buffer-no-eof|readable-from-list|readable-legacy-drain|readable-non-empty-end|readable-wrap|set-encoding|transform|writable).js':
+    [bufferRequire],
+  'test/browser/test-stream3-pause-then-read.js':
+    [bufferRequire],
   'test/parallel/test-stream-(add-abort-signal|drop-take|duplex-destroy|flatMap|forEach|filter|finished|readable-destroy|reduce|toArray|writable-destroy).js':
     [testPolyfills]
 }

build/replacements.mjs

@@ -34,8 +34,6 @@ const internalStreamsNoRequireAbortController = [
 
 const internalStreamsRequireInternal = ["require\\('internal/([^']+)'\\)", "require('../$1')"]
 
-const internalStreamsNoRequireBuffer = ["const \\{ Buffer \\} = require\\('buffer'\\);", '']
-
 const internalStreamsRequireErrors = ["require\\('internal/errors'\\)", "require('../../ours/errors')"]
 
 const internalStreamsRequireEventEmitter = ['const EE =', 'const { EventEmitter: EE } =']
@@ -233,7 +231,6 @@ export const replacements = {
     internalStreamsNoRequireAbortController
   ],
   'lib/internal/streams/.+': [
-    internalStreamsNoRequireBuffer,
     internalStreamsRequireErrors,
     internalStreamsRequireEventEmitter,
     internalStreamsRequirePrimordials,

lib/internal/streams/buffer_list.js

@@ -2,6 +2,8 @@
 
 const { StringPrototypeSlice, SymbolIterator, TypedArrayPrototypeSet, Uint8Array } = require('../../ours/primordials')
 
+const { Buffer } = require('buffer')
+
 const { inspect } = require('../../ours/util')
 
 module.exports = class BufferList {

lib/internal/streams/destroy.js

@@ -1,5 +1,10 @@
 'use strict'
 
+/* replacement start */
+
+const process = require('process')
+/* replacement end */
+
 const {
   aggregateTwoErrors,
   codes: { ERR_MULTIPLE_CALLBACK },

lib/internal/streams/duplexify.js

@@ -1,4 +1,8 @@
-'use strict'
+/* replacement start */
+const process = require('process')
+/* replacement end */
+
+;('use strict')
 
 const bufferModule = require('buffer')
 

lib/internal/streams/end-of-stream.js

@@ -1,6 +1,10 @@
+/* replacement start */
+const process = require('process')
+/* replacement end */
 // Ported from https://github.com/mafintosh/end-of-stream with
 // permission from the author, Mathias Buus (@mafintosh).
-'use strict'
+
+;('use strict')
 
 const { AbortError, codes } = require('../../ours/errors')
 

lib/internal/streams/from.js

@@ -1,7 +1,14 @@
 'use strict'
 
+/* replacement start */
+
+const process = require('process')
+/* replacement end */
+
 const { PromisePrototypeThen, SymbolAsyncIterator, SymbolIterator } = require('../../ours/primordials')
 
+const { Buffer } = require('buffer')
+
 const { ERR_INVALID_ARG_TYPE, ERR_STREAM_NULL_VALUES } = require('../../ours/errors').codes
 
 function from(Readable, iterable, opts) {

lib/internal/streams/pipeline.js

@@ -1,6 +1,10 @@
+/* replacement start */
+const process = require('process')
+/* replacement end */
 // Ported from https://github.com/mafintosh/pump with
 // permission from the author, Mathias Buus (@mafintosh).
-'use strict'
+
+;('use strict')
 
 const { ArrayIsArray, Promise, SymbolAsyncIterator } = require('../../ours/primordials')
 

lib/internal/streams/readable.js

@@ -1,3 +1,6 @@
+/* replacement start */
+const process = require('process')
+/* replacement end */
 // Copyright Joyent, Inc. and other Node contributors.
 //
 // Permission is hereby granted, free of charge, to any person obtaining a
@@ -18,7 +21,8 @@
 // DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR
 // OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
 // USE OR OTHER DEALINGS IN THE SOFTWARE.
-'use strict'
+
+;('use strict')
 
 const {
   ArrayPrototypeIndexOf,
@@ -41,6 +45,8 @@ const { EventEmitter: EE } = require('events')
 
 const { Stream, prependListener } = require('./legacy')
 
+const { Buffer } = require('buffer')
+
 const { addAbortSignal } = require('./add-abort-signal')
 
 const eos = require('./end-of-stream')