Skip to content
This repository was archived by the owner on Aug 11, 2020. It is now read-only.

Commit e244ba9

Browse files
committed
quic: address multiple nits
1 parent 802836d commit e244ba9

File tree

4 files changed

+14
-12
lines changed

4 files changed

+14
-12
lines changed

doc/api/quic.md

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ socket.on('listening', () => {
5858

5959
## QUIC Basics
6060

61-
QUIC is a UDP-based network transport protocol that includes built in security
61+
QUIC is a UDP-based network transport protocol that includes built-in security
6262
via TLS 1.3, flow control, error correction, connection migration,
6363
multiplexing, and more.
6464

@@ -388,7 +388,7 @@ added: REPLACEME
388388

389389
* Type: {BigInt}
390390

391-
A `BigInt` representing the number of retranmissions caused by delayed
391+
A `BigInt` representing the number of retransmissions caused by delayed
392392
acknowledgements.
393393

394394
#### quicsession.address
@@ -448,7 +448,7 @@ added: REPLACEME
448448

449449
* Type: {number}
450450

451-
The total number of unacknoledged bytes this QUIC endpoint has tramitted
451+
The total number of unacknowledged bytes this QUIC endpoint has transmitted
452452
to the connected peer.
453453

454454
#### quicsession.bytesReceived
@@ -630,7 +630,7 @@ added: REPLACEME
630630

631631
* Type: {BigInt}
632632

633-
A `BigInt` representing the number of lost-packet retranmissions that have been
633+
A `BigInt` representing the number of lost-packet retransmissions that have been
634634
performed on this `QuicSession`.
635635

636636
#### quicsession.maxDataLeft
@@ -650,7 +650,7 @@ added: REPLACEME
650650

651651
* Type: {BigInt}
652652

653-
A `BigInt` representing the maximum number of in flight bytes recorded
653+
A `BigInt` representing the maximum number of in-flight bytes recorded
654654
for this `QuicSession`.
655655

656656
#### quicsession.maxStreams
@@ -711,7 +711,7 @@ added: REPLACEME
711711

712712
* Type: {BigInt}
713713

714-
A `BigInt` representing the total number of `QuicStreams` initated by the
714+
A `BigInt` representing the total number of `QuicStreams` initiated by the
715715
connected peer.
716716

717717
#### quicsession.remoteAddress
@@ -928,7 +928,7 @@ added: REPLACEME
928928
-->
929929

930930
* `servername` {String} A DNS name to associate with the given context.
931-
* `context` {Object} A TLS SecureContext to associate with the `servername`.
931+
* `context` {tls.SecureContext} A TLS SecureContext to associate with the `servername`.
932932

933933
TBD
934934

@@ -1604,7 +1604,7 @@ added: REPLACEME
16041604
-->
16051605
* Type: {boolean}
16061606

1607-
True if dataflow on the `QuicStream` was prematured terminated.
1607+
True if dataflow on the `QuicStream` was prematurely terminated.
16081608

16091609
#### quicstream.bidirectional
16101610
<!--YAML

src/node_quic_session.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -592,7 +592,7 @@ void JSQuicSessionListener::OnSessionTicket(int size, SSL_SESSION* session) {
592592

593593
AllocatedBuffer session_ticket = env->AllocateManaged(size);
594594
unsigned char* session_data =
595-
reinterpret_cast<unsigned char*>(session_ticket.data());
595+
reinterpret_cast<unsigned char*>(session_ticket.data());
596596
memset(session_data, 0, size);
597597
i2d_SSL_SESSION(session, &session_data);
598598
if (!session_ticket.empty())

src/node_quic_session.h

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -195,7 +195,9 @@ enum QuicSessionStatsIdx : int {
195195
IDX_QUIC_SESSION_STATS_RETRY_COUNT,
196196
IDX_QUIC_SESSION_STATS_LOSS_RETRANSMIT_COUNT,
197197
IDX_QUIC_SESSION_STATS_ACK_DELAY_RETRANSMIT_COUNT,
198-
IDX_QUIC_SESSION_STATS_PATH_VALIDATION_SUCCESS_COUNT,IDX_QUIC_SESSION_STATS_PATH_VALIDATION_FAILURE_COUNT,IDX_QUIC_SESSION_STATS_MAX_BYTES_IN_FLIGHT
198+
IDX_QUIC_SESSION_STATS_PATH_VALIDATION_SUCCESS_COUNT,
199+
IDX_QUIC_SESSION_STATS_PATH_VALIDATION_FAILURE_COUNT,
200+
IDX_QUIC_SESSION_STATS_MAX_BYTES_IN_FLIGHT
199201
};
200202

201203
class QuicSessionListener {

src/node_sockaddr-inl.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -132,12 +132,12 @@ SocketAddress::SocketAddress(const SocketAddress& addr) {
132132
memcpy(&address_, &addr.address_, addr.GetLength());
133133
}
134134

135-
inline SocketAddress& SocketAddress::operator=(const sockaddr* addr) {
135+
SocketAddress& SocketAddress::operator=(const sockaddr* addr) {
136136
memcpy(&address_, addr, GetLength(addr));
137137
return *this;
138138
}
139139

140-
inline SocketAddress& SocketAddress::operator=(const SocketAddress& addr) {
140+
SocketAddress& SocketAddress::operator=(const SocketAddress& addr) {
141141
memcpy(&address_, &addr.address_, addr.GetLength());
142142
}
143143

0 commit comments

Comments
 (0)