src: fix BaseObject Detach for GC’ed objects

addaleax · jasnell · commit 142ee344fefd · 2019-10-03T11:27:44.000-07:00
This fixes a crash in test/sequential/test-performance-eventloopdelay.js. This should be squashed into > src: introduce custom smart pointers for `BaseObject`s PR-URL: #149 Reviewed-By: James M Snell <jasnell@gmail.com>
diff --git a/src/base_object-inl.h b/src/base_object-inl.h
@@ -187,15 +187,15 @@ void BaseObject::decrease_refcount() {
   if (new_refcount == 0) {
     if (metadata->is_detached) {
       delete this;
-    } else if (metadata->wants_weak_jsobj) {
+    } else if (metadata->wants_weak_jsobj && !persistent_handle_.IsEmpty()) {
       MakeWeak();
     }
   }
 }
 
 void BaseObject::increase_refcount() {
   unsigned int prev_refcount = pointer_data()->strong_ptr_count++;
-  if (prev_refcount == 0)
+  if (prev_refcount == 0 && !persistent_handle_.IsEmpty())
     persistent_handle_.ClearWeak();
 }
 

Original file line number	Diff line number	Diff line change
`@@ -187,15 +187,15 @@ void BaseObject::decrease_refcount() {`
`187`	`187`	`if (new_refcount == 0) {`
`188`	`188`	`if (metadata->is_detached) {`
`189`	`189`	`delete this;`
`190`		`- } else if (metadata->wants_weak_jsobj) {`
	`190`	`+ } else if (metadata->wants_weak_jsobj && !persistent_handle_.IsEmpty()) {`
`191`	`191`	`MakeWeak();`
`192`	`192`	`}`
`193`	`193`	`}`
`194`	`194`	`}`
`195`	`195`
`196`	`196`	`void BaseObject::increase_refcount() {`
`197`	`197`	`unsigned int prev_refcount = pointer_data()->strong_ptr_count++;`
`198`		`- if (prev_refcount == 0)`
	`198`	`+ if (prev_refcount == 0 && !persistent_handle_.IsEmpty())`
`199`	`199`	`persistent_handle_.ClearWeak();`
`200`	`200`	`}`
`201`	`201`