chore: enforce linefeeds at eols in the .gitattributes file [skip ci]
#28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RaisinTen
requested review from
dsanders11,
jviotti and
robertgzr
as code owners
3 tasks
|
Should we narrow the scope of this? Just to avoid unintended side effects. Both Chromium and Electron change it on a per-file type basis rather than everything, for example. We could limit it to the file types we care about: Also, can we change the commit message? I think mentioning |
RaisinTen
force-pushed
the
add-.gitattributes-file
branch
from
a5a5316 to
8ea3b71
Compare
RaisinTen
changed the title
core.autocrlf to false in the .gitattributes filelinefeeds at eols in the .gitattributes file
|
@dsanders11 done, PTAL! |
We should avoid making changes to the global git config if we can help it. This change stops setting the value for core.autocrlf globally on CI by moving it to the .gitattributes file which is local to a git repository. This should help out with removing this change from https://github.com/postmanlabs/postject/pull/8/files#diff-78a8a19706dbd2a4425dd72bdab0502ed7a2cef16365ab7030a5a0588927bf47R68-R69. Refs: https://stackoverflow.com/a/52996849 Signed-off-by: Darshan Sen <raisinten@gmail.com>
dsanders11
force-pushed
the
add-.gitattributes-file
branch
from
8ea3b71 to
fb92d80
Compare
dsanders11
changed the title
linefeeds at eols in the .gitattributes filelinefeeds at eols in the .gitattributes file [skip ci]
dsanders11
approved these changes
Sep 27, 2022
There was a problem hiding this comment.
@RaisinTen, LGTM. I rebased it to test the semantic commit check (worked as expected) and then moved [skip ci] to the end of the commit message to make the check happy, which also worked as expected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should avoid making changes to the global git config if we can help it. This change stops setting the value for
core.autocrlfglobally on CI by moving it to the.gitattributesfile which is local to a git repository.This should help out with removing this change from
https://github.com/postmanlabs/postject/pull/8/files#diff-78a8a19706dbd2a4425dd72bdab0502ed7a2cef16365ab7030a5a0588927bf47R68-R69.
Refs: https://stackoverflow.com/a/52996849
Signed-off-by: Darshan Sen raisinten@gmail.com