Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use again the cpuset after compare function fix #163

Merged
merged 1 commit into from
Apr 13, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion benchmarks/community-benchmark/run.sh
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ echo "The following are optional across both use cases"
echo "RUNS = defaults to empty"
echo "FILTER = defaults to empty"
echo "MACHINE_THREADS - used for building node. Defaults to all threads on machine"
echo "CPUSET - used for pinning to specific CPU cores. Default to 0-11 (performance cores)"
}

if [ -z $PULL_ID ]; then
Expand All @@ -53,6 +54,7 @@ fi
mandatory CATEGORY
optional RUNS
optional FILTER
optional CPUSET "0-11"
getMACHINE_THREADS=`cat /proc/cpuinfo |grep processor|tail -n1|awk {'print $3'}`
let getMACHINE_THREADS=getMACHINE_THREADS+1 #getting threads this way is 0 based. Add one
optional MACHINE_THREADS $getMACHINE_THREADS
Expand Down Expand Up @@ -96,13 +98,16 @@ fi
if [ -n "$RUNS" ]; then
RUNS="--runs ${RUNS}"
fi
if [ -n "$CPUSET" ]; then
CPUSET="--set CPUSET=${CPUSET}"
fi
# run benchmark
fileName=output`date +%d%m%y-%H%M%S`.csv
echo "Output will be saved to $fileName"
pwd

# Run on performance cores
taskset -c 0-11 ./node-master benchmark/compare.js --old ./node-master --new ./node-pr $FILTER $RUNS -- $CATEGORY | tee $fileName
./node-master benchmark/compare.js $CPUSET --old ./node-master --new ./node-pr $FILTER $RUNS -- $CATEGORY | tee $fileName

cat $fileName | Rscript benchmark/compare.R
mv $fileName $startDir