Conversation
richardlau
approved these changes
Apr 10, 2024
anonrig
reviewed
Apr 10, 2024
| ./node-master benchmark/compare.js --old ./node-master --new ./node-pr $FILTER $RUNS -- $CATEGORY | tee $fileName | ||
|
|
||
| # Run on performance cores | ||
| taskset -c 0-11 ./node-master benchmark/compare.js --old ./node-master --new ./node-pr $FILTER $RUNS -- $CATEGORY | tee $fileName |
Member
There was a problem hiding this comment.
This would fail on non-linux environments I assume? Can we make it work with Windows and macOS as well?
Member
Author
There was a problem hiding this comment.
as @richardlau is not runnable outside the build infra
Member
FWIW the script is currently specific to the Build infra as it uses the |
Member
Author
|
maybe we can close this if we merge |
mcollina
approved these changes
Apr 10, 2024
Member
mcollina
left a comment
There was a problem hiding this comment.
lgtm
we are not running these in anything but linux
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this should fix the issue with
tasksetin the compare CLI:not configurable to avoid command injection possibility
After merging this, should revert the pr: