Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove CPUSET due to a it not working as we see a lot of NaN in the results #161

Merged
merged 1 commit into from
Apr 10, 2024
Merged

remove CPUSET due to a it not working as we see a lot of NaN in the results #161

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions benchmarks/community-benchmark/run.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@ echo "The following are optional across both use cases"
echo "RUNS = defaults to empty"
echo "FILTER = defaults to empty"
echo "MACHINE_THREADS - used for building node. Defaults to all threads on machine"
echo "CPUSET - used for pinning to specific CPU cores. Default to 0-11 (performance cores)"
}

if [ -z $PULL_ID ]; then
Expand All @@ -54,7 +53,6 @@ fi
mandatory CATEGORY
optional RUNS
optional FILTER
optional CPUSET "0-11"
getMACHINE_THREADS=`cat /proc/cpuinfo |grep processor|tail -n1|awk {'print $3'}`
let getMACHINE_THREADS=getMACHINE_THREADS+1 #getting threads this way is 0 based. Add one
optional MACHINE_THREADS $getMACHINE_THREADS
Expand Down Expand Up @@ -98,14 +96,11 @@ fi
if [ -n "$RUNS" ]; then
RUNS="--runs ${RUNS}"
fi
if [ -n "$CPUSET" ]; then
CPUSET="--set CPUSET=${CPUSET}"
fi
# run benchmark
fileName=output`date +%d%m%y-%H%M%S`.csv
echo "Output will be saved to $fileName"
pwd
./node-master benchmark/compare.js $CPUSET --old ./node-master --new ./node-pr $FILTER $RUNS -- $CATEGORY | tee $fileName
./node-master benchmark/compare.js --old ./node-master --new ./node-pr $FILTER $RUNS -- $CATEGORY | tee $fileName

cat $fileName | Rscript benchmark/compare.R
mv $fileName $startDir