Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove CPUSET due to a it not working as we see a lot of NaN in the results #161

Merged
merged 1 commit into from
Apr 10, 2024
Merged

remove CPUSET due to a it not working as we see a lot of NaN in the results #161

merged 1 commit into from
Apr 10, 2024

Conversation

rluvaton
Copy link
Member

@anonrig anonrig merged commit f945bb5 into main Apr 10, 2024
@anonrig anonrig deleted the remove-cpuset branch April 10, 2024 18:40
thisalihassan added a commit to thisalihassan/node that referenced this pull request Apr 10, 2024
@thisalihassan
benchmark: add ipc support to spawn stdio config
d1005fb 
Enabled inter-process communication (ipc) in the stdio configuration
of the spawn function within the benchmark subsystem.
This change allows for improved data exchange between parent
and benchmarked child processes, addressing limitations in performance
testing scenarios.

Fixes: nodejs#52233
Refs: nodejs/performance#161
@thisalihassan thisalihassan mentioned this pull request Apr 10, 2024
Closed
nodejs-github-bot pushed a commit to nodejs/node that referenced this pull request Apr 13, 2024
@thisalihassan @nodejs-github-bot
benchmark: add ipc support to spawn stdio config
021e172 
Enabled inter-process communication (ipc) in the stdio configuration
of the spawn function within the benchmark subsystem.
This change allows for improved data exchange between parent
and benchmarked child processes, addressing limitations in performance
testing scenarios.

Fixes: #52233
Refs: nodejs/performance#161
PR-URL: #52456
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Raz Luvaton <rluvaton@gmail.com>
nodejs-github-bot pushed a commit to nodejs/node that referenced this pull request Apr 13, 2024
@thisalihassan @nodejs-github-bot
benchmark: inherit stdio/stderr instead of pipe
82891ae 
PR-URL: #52456
Fixes: #52233
Refs: nodejs/performance#161
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Raz Luvaton <rluvaton@gmail.com>
aduh95 pushed a commit to nodejs/node that referenced this pull request Apr 29, 2024
@thisalihassan @aduh95
benchmark: add ipc support to spawn stdio config
7b82c17 
Enabled inter-process communication (ipc) in the stdio configuration
of the spawn function within the benchmark subsystem.
This change allows for improved data exchange between parent
and benchmarked child processes, addressing limitations in performance
testing scenarios.

Fixes: #52233
Refs: nodejs/performance#161
PR-URL: #52456
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Raz Luvaton <rluvaton@gmail.com>
aduh95 pushed a commit to nodejs/node that referenced this pull request Apr 29, 2024
@thisalihassan @aduh95
benchmark: inherit stdio/stderr instead of pipe
7cdfe8a 
PR-URL: #52456
Fixes: #52233
Refs: nodejs/performance#161
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Raz Luvaton <rluvaton@gmail.com>
marco-ippolito pushed a commit to nodejs/node that referenced this pull request May 2, 2024
@thisalihassan @marco-ippolito
benchmark: add ipc support to spawn stdio config
11887d5 
Enabled inter-process communication (ipc) in the stdio configuration
of the spawn function within the benchmark subsystem.
This change allows for improved data exchange between parent
and benchmarked child processes, addressing limitations in performance
testing scenarios.

Fixes: #52233
Refs: nodejs/performance#161
PR-URL: #52456
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Raz Luvaton <rluvaton@gmail.com>
marco-ippolito pushed a commit to nodejs/node that referenced this pull request May 2, 2024
@thisalihassan @marco-ippolito
benchmark: inherit stdio/stderr instead of pipe
c96df78 
PR-URL: #52456
Fixes: #52233
Refs: nodejs/performance#161
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Raz Luvaton <rluvaton@gmail.com>
marco-ippolito pushed a commit to nodejs/node that referenced this pull request May 3, 2024
@thisalihassan @marco-ippolito
benchmark: add ipc support to spawn stdio config
0300598 
Enabled inter-process communication (ipc) in the stdio configuration
of the spawn function within the benchmark subsystem.
This change allows for improved data exchange between parent
and benchmarked child processes, addressing limitations in performance
testing scenarios.

Fixes: #52233
Refs: nodejs/performance#161
PR-URL: #52456
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Raz Luvaton <rluvaton@gmail.com>
marco-ippolito pushed a commit to nodejs/node that referenced this pull request May 3, 2024
@thisalihassan @marco-ippolito
benchmark: inherit stdio/stderr instead of pipe
2274d0c 
PR-URL: #52456
Fixes: #52233
Refs: nodejs/performance#161
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Raz Luvaton <rluvaton@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anonrig anonrig anonrig approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rluvaton @anonrig