Do not parse numbers on url parsers - ipv4

[anonrig]

EndsInNumber parses the number, but does not use the result of it. Just using the validations, without the parsing, would make ipv4 parsing 28% faster.

Similar comparison is: ada-url/ada#36

[debadree25]

So basically instead of int64_t num = ParseIPv4Number(last_str, last_str + last.size()); we would just use a validator here?

[anonrig]

There are 2 optimizations can be done here.

1. Removing vector initialization on line 412

std::vector<std::string> parts = SplitString(input, '.', false);

2. Removing ParseIPv4Number and replacing it with a validator that returns boolean

int64_t num = ParseIPv4Number(last_str, last_str + last.size());

[debadree25]

Understood! Thanks! will attempt this!

[miguelteixeiraa]

I'm really sorry @debadree25 ! : ((
I was already working on it and should have commented something here.
I apologize for that

[debadree25]

I'm really sorry @debadree25 ! : (( I was already working on it and should have commented something here. I apologize for that

No issue at all checking out your PR to learn!!