Skip to content

chore(ESP): use campaign link for HeroDevs #7778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 28, 2025

Conversation

avivkeller
Copy link
Member

Refs: #7773

I don't think anyone objected to this change in particular.

Signed-off-by: Aviv Keller <me@aviv.sh>
@Copilot Copilot AI review requested due to automatic review settings May 26, 2025 15:51
@avivkeller avivkeller requested a review from a team as a code owner May 26, 2025 15:51
Copy link

vercel bot commented May 26, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview May 26, 2025 3:52pm

@avivkeller
Copy link
Member Author

FYI @joeeames

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the HeroDevs support link to use a campaign-specific URL for tracking purposes.

  • Updated the HeroDevs link in the previous releases page to include query parameters for campaign tracking.
  • Ensures that commercial support information references the appropriate updated link.
Comments suppressed due to low confidence (1)

apps/site/pages/en/about/previous-releases.mdx:21

  • Please verify that the updated campaign link is accurate and resolves as expected at the HeroDevs site. Additionally, ensure that query parameters are encoded correctly if necessary.
+Commercial support for versions past the Maintenance phase is available through our OpenJS Ecosystem Sustainability Program partner [HeroDevs](https://www.herodevs.com/support/node-nes?utm_source=NodeJS+&utm_medium=Link&utm_campaign=Version_support_page).

@codecov-commenter
Copy link

codecov-commenter commented May 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.33%. Comparing base (d261c9f) to head (b7bb311).

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7778      +/-   ##
==========================================
- Coverage   75.34%   75.33%   -0.02%     
==========================================
  Files          96       96              
  Lines        7861     7861              
  Branches      192      192              
==========================================
- Hits         5923     5922       -1     
- Misses       1937     1938       +1     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

github-actions bot commented May 27, 2025

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🔴 68 🟢 100 🟢 100 🟢 91 🔗
/en/about 🟢 100 🟢 100 🟢 100 🟠 82 🔗
/en/about/previous-releases 🟢 100 🟢 100 🟢 100 🟠 83 🔗
/en/download 🟢 98 🟢 100 🟢 100 🟢 91 🔗
/en/blog 🟢 99 🟢 100 🟢 96 🟢 92 🔗

@bmuenzenmeyer bmuenzenmeyer added this pull request to the merge queue May 28, 2025
Merged via the queue into main with commit fdcc668 May 28, 2025
20 of 21 checks passed
@bmuenzenmeyer bmuenzenmeyer deleted the chore/use-campaign-link-herodevs branch May 28, 2025 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants