-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
chore(ESP): use campaign link for HeroDevs #7778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Aviv Keller <me@aviv.sh>
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
FYI @joeeames |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the HeroDevs support link to use a campaign-specific URL for tracking purposes.
- Updated the HeroDevs link in the previous releases page to include query parameters for campaign tracking.
- Ensures that commercial support information references the appropriate updated link.
Comments suppressed due to low confidence (1)
apps/site/pages/en/about/previous-releases.mdx:21
- Please verify that the updated campaign link is accurate and resolves as expected at the HeroDevs site. Additionally, ensure that query parameters are encoded correctly if necessary.
+Commercial support for versions past the Maintenance phase is available through our OpenJS Ecosystem Sustainability Program partner [HeroDevs](https://www.herodevs.com/support/node-nes?utm_source=NodeJS+&utm_medium=Link&utm_campaign=Version_support_page).
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #7778 +/- ##
==========================================
- Coverage 75.34% 75.33% -0.02%
==========================================
Files 96 96
Lines 7861 7861
Branches 192 192
==========================================
- Hits 5923 5922 -1
- Misses 1937 1938 +1
Partials 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Lighthouse Results
|
Refs: #7773
I don't think anyone objected to this change in particular.