Skip to content

Conversation

danielleadams
Copy link
Contributor

@danielleadams danielleadams commented Jul 18, 2023

Refs: nodejs/node#48694

Description

Validation

Related Issues

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npx turbo lint to ensure the code follows the style guide. And run npx turbo lint:fix to fix the style errors if necessary.
  • I have run npx turbo format to ensure the code follows the style guide.
  • I have run npx turbo test to check if all tests are passing, and/or npx turbo test:snapshot to update snapshots if I created and/or updated React Components.
  • I've covered new added functionality with unit tests if necessary.

@danielleadams danielleadams requested a review from a team as a code owner July 18, 2023 19:54
@vercel
Copy link

vercel bot commented Jul 18, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 18, 2023 7:56pm
nodejs-org-stories ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 18, 2023 7:56pm

@vercel vercel bot temporarily deployed to Preview – nodejs-org-stories July 18, 2023 19:55 Inactive
@juanarbol
Copy link
Member

Lgtm

@vercel vercel bot temporarily deployed to Preview – nodejs-org July 18, 2023 19:56 Inactive
@github-actions
Copy link
Contributor

📦 Next.js Bundle Analysis for nodejs.org

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@danielleadams danielleadams merged commit dbe8ff8 into main Jul 18, 2023
@danielleadams danielleadams deleted the post-v18.17.0 branch July 18, 2023 20:05
bmuenzenmeyer pushed a commit to bmuenzenmeyer/nodejs.org that referenced this pull request Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants