Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add version toggle to download page #357

Merged
merged 4 commits into from
Nov 17, 2015
Merged

Add version toggle to download page #357

merged 4 commits into from
Nov 17, 2015

Conversation

rnsloan
Copy link
Contributor

@rnsloan rnsloan commented Nov 13, 2015

Fixes #321

  • Add toggle
  • remove top-right menu

1


2


3

@fhemberger
Copy link
Contributor

Wow, awesome! 👍

@bnb
Copy link
Contributor

bnb commented Nov 13, 2015

Rally rad! 👍

@lpinca
Copy link
Member

lpinca commented Nov 13, 2015

It looks great.

@phillipj
Copy link
Member

+:100:

@stevemao
Copy link
Contributor

The images look awesome :) has anyone else tested this yet?

@diagramatics
Copy link
Contributor

How about a different active color for LTS and stable, just to indicate which version the user is going to download easier?

@bnb
Copy link
Contributor

bnb commented Nov 14, 2015

@diagramatics I was looking at the gif, and noticed that the Windows/OS X/Source parts have a dark gray background on hover. Maybe that could be used?

@rnsloan
Copy link
Contributor Author

rnsloan commented Nov 16, 2015

@bnb like this?

full

black

@bnb
Copy link
Contributor

bnb commented Nov 16, 2015

@rnsloan Yes, except keep the bright green (from the previous version) for the active state.

Notice how the gray background is only visible on hover for the Windows/Mac/Source buttons. Like that, except with the green background as an active state.

@rnsloan
Copy link
Contributor Author

rnsloan commented Nov 17, 2015

Colors updated. Merging.

rnsloan added a commit that referenced this pull request Nov 17, 2015
Add version toggle to download page
@rnsloan rnsloan merged commit 2b1ac04 into nodejs:master Nov 17, 2015
@phillipj
Copy link
Member

👯 nice work!

@bnb
Copy link
Contributor

bnb commented Nov 17, 2015

Good job. Looks awesome live!

@stevemao
Copy link
Contributor

Perfect, Thanks @rnsloan :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants