Skip to content

Update Docker example to use most recent LTS #2983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Apr 2, 2020
Merged

Update Docker example to use most recent LTS #2983

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
4963950
Update Docker example to use most recent LTS
jamesmacfie Feb 25, 2020
3166b20
Change NODE from v10 to v12 in more locales
jamesmacfie Feb 25, 2020
f5556b7
Merge branch 'master' into patch-1
Trott Feb 26, 2020
1cfd315
Merge branch 'master' into patch-1
SEWeiTung Mar 12, 2020
72fce1f
Merge branch 'master' into patch-1
SEWeiTung Mar 13, 2020
7177169
Merge branch 'master' into patch-1
SEWeiTung Apr 2, 2020
834d00a
Update nodejs-docker-webapp.md
SEWeiTung Apr 2, 2020
e6cad22
ja-JP: Trans fixed
SEWeiTung Apr 2, 2020
c53318c
ko: Trans fixed
SEWeiTung Apr 2, 2020
66afa62
ja-JP: Trans fixed
SEWeiTung Apr 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions locale/en/docs/guides/nodejs-docker-webapp.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,11 +80,11 @@ touch Dockerfile
Open the `Dockerfile` in your favorite text editor

The first thing we need to do is define from what image we want to build from.
Here we will use the latest LTS (long term support) version `10` of `node`
Here we will use the latest LTS (long term support) version `12` of `node`
available from the [Docker Hub](https://hub.docker.com/):

```docker
FROM node:10
FROM node:12
```

Next we create a directory to hold the application code inside the image, this
Expand Down Expand Up @@ -143,7 +143,7 @@ CMD [ "node", "server.js" ]
Your `Dockerfile` should now look like this:

```docker
FROM node:10
FROM node:12

# Create app directory
WORKDIR /usr/src/app
Expand Down Expand Up @@ -194,7 +194,7 @@ $ docker images

# Example
REPOSITORY TAG ID CREATED
node 10 1934b0b038d1 5 days ago
node 12 1934b0b038d1 5 days ago
<your username>/node-web-app latest d64d3505b0d2 1 minute ago
```

Expand Down
16 changes: 8 additions & 8 deletions locale/ja/docs/guides/nodejs-docker-webapp.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,11 +155,11 @@ touch Dockerfile
Open the `Dockerfile` in your favorite text editor

The first thing we need to do is define from what image we want to build from.
Here we will use the latest LTS (long term support) version `10` of `node`
Here we will use the latest LTS (long term support) version `12` of `node`
available from the [Docker Hub](https://hub.docker.com/):

```docker
FROM node:10
FROM node:12
```

Next we create a directory to hold the application code inside the image, this
Expand Down Expand Up @@ -216,7 +216,7 @@ CMD [ "node", "server.js" ]
Your `Dockerfile` should now look like this:

```docker
FROM node:10
FROM node:12

# Create app directory
WORKDIR /usr/src/app
Expand Down Expand Up @@ -250,10 +250,10 @@ touch Dockerfile

最初にしなければならないことは、どのイメージから構築したいかを定義することです。
ここでは[Docker Hub](https://hub.docker.com/)から入手できる
`node` の最新の LTS (long term support) バージョン `10` を使います。
`node` の最新の LTS (long term support) バージョン `12` を使います。

```docker
FROM node:10
FROM node:12
```

次に、イメージ内にアプリケーションコードを入れるディレクトリを作成します。
Expand Down Expand Up @@ -311,7 +311,7 @@ CMD [ "node", "server.js" ]
`Dockerfile` はこのようになっているはずです。

```docker
FROM node:10
FROM node:12

# アプリケーションディレクトリを作成する
WORKDIR /usr/src/app
Expand Down Expand Up @@ -378,7 +378,7 @@ $ docker images

# Example
REPOSITORY TAG ID CREATED
node 8 1934b0b038d1 5 days ago
node 12 1934b0b038d1 5 days ago
<your username>/node-web-app latest d64d3505b0d2 1 minute ago
```

Expand All @@ -400,7 +400,7 @@ $ docker images

# 例
REPOSITORY TAG ID CREATED
node 8 1934b0b038d1 5 days ago
node 12 1934b0b038d1 5 days ago
<your username>/node-web-app latest d64d3505b0d2 1 minute ago
```

Expand Down
14 changes: 7 additions & 7 deletions locale/ko/docs/guides/nodejs-docker-webapp.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,11 +151,11 @@ touch Dockerfile
Open the `Dockerfile` in your favorite text editor

The first thing we need to do is define from what image we want to build from.
Here we will use the latest LTS (long term support) version `10` of `node`
Here we will use the latest LTS (long term support) version `12` of `node`
available from the [Docker Hub](https://hub.docker.com/):

```docker
FROM node:10
FROM node:12
```
-->

Expand All @@ -171,10 +171,10 @@ touch Dockerfile

가장 먼저 해야 할 것은 어떤 이미지를 사용해서 빌드할 것인지를 정의하는 것입니다. 여기서는
[Docker Hub](https://hub.docker.com/)에 있는
`node`의 최신 LTS(장기 지원) 버전인 `10`을 사용할 것입니다.
`node`의 최신 LTS(장기 지원) 버전인 `12`을 사용할 것입니다.

```docker
FROM node:10
FROM node:12
```

<!--
Expand Down Expand Up @@ -282,7 +282,7 @@ CMD [ "node", "server.js" ]
Your `Dockerfile` should now look like this:

```docker
FROM node:10
FROM node:12

# Create app directory
WORKDIR /usr/src/app
Expand Down Expand Up @@ -314,7 +314,7 @@ CMD [ "node", "server.js" ]
`Dockerfile`은 다음과 같아야 합니다.

```docker
FROM node:10
FROM node:12

# 앱 디렉터리 생성
WORKDIR /usr/src/app
Expand Down Expand Up @@ -402,7 +402,7 @@ $ docker images

# 예시
REPOSITORY TAG ID CREATED
node 8 1934b0b038d1 5 days ago
node 12 1934b0b038d1 5 days ago
<your username>/node-web-app latest d64d3505b0d2 1 minute ago
```

Expand Down
8 changes: 4 additions & 4 deletions locale/ru/docs/guides/nodejs-docker-webapp.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,13 +80,13 @@ touch Dockerfile

Первое, что нам надо сделать — определить базовый образ,
который будет взят за основу. Мы будем использовать образ `node` последней версии
LTS* (версии с долгосрочной поддержкой) — `10`,
LTS* (версии с долгосрочной поддержкой) — `12`,
доступный на [Docker Hub](https://hub.docker.com/).

\* Прим. переводчика: на момент написания статьи.

```docker
FROM node:10
FROM node:12
```

Затем создадим директорию для кода приложения внутри образа.
Expand Down Expand Up @@ -148,7 +148,7 @@ CMD [ "node", "server.js" ]
Ваш `Dockerfile` теперь должен выглядеть примерно так:

```docker
FROM node:10
FROM node:12

# создание директории приложения
WORKDIR /usr/src/app
Expand Down Expand Up @@ -200,7 +200,7 @@ $ docker images

# пример вывода
repository tag id created
node 10 1934b0b038d1 5 days ago
node 12 1934b0b038d1 5 days ago
<your username>/node-web-app latest d64d3505b0d2 1 minute ago
```

Expand Down
8 changes: 4 additions & 4 deletions locale/zh-cn/docs/guides/nodejs-docker-webapp.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,10 +66,10 @@ touch Dockerfile

用你最喜欢的文本编辑器打开这个 `Dockerfile`。

我们要做的第一件事是定义我们需要从哪个镜像进行构建。这里我们将使用最新的 LTS（长期服务器支持版），`Node` 的版本号为 `10`。你可以从 [Docker 站点](https://hub.docker.com/) 获取相关镜像：
我们要做的第一件事是定义我们需要从哪个镜像进行构建。这里我们将使用最新的 LTS（长期服务器支持版），`Node` 的版本号为 `12`。你可以从 [Docker 站点](https://hub.docker.com/) 获取相关镜像：

```docker
FROM node:10
FROM node:12
```

下一步在镜像中创建一个文件夹存放应用程序代码，这将是你的应用程序工作目录：
Expand Down Expand Up @@ -117,7 +117,7 @@ CMD [ "node", "server.js" ]
你的 `Dockerfile` 现在看上去是这个样子：

```docker
FROM node:10
FROM node:12

# Create app directory
WORKDIR /usr/src/app
Expand Down Expand Up @@ -164,7 +164,7 @@ $ docker images

# Example
REPOSITORY TAG ID CREATED
node 8 1934b0b038d1 5 days ago
node 12 1934b0b038d1 5 days ago
<your username>/node-web-app latest d64d3505b0d2 1 minute ago
```

Expand Down