Skip to content

zh-tw: update & improve translations #2791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Nov 28, 2019
Merged

zh-tw: update & improve translations #2791

merged 7 commits into from
Nov 28, 2019

Conversation

@pan93412
Copy link
Contributor

Also updated the base.

Signed-off-by: pan93412 pan93412@gmail.com

@pan93412 pan93412 force-pushed the zh-tw-translations-191121 branch 2 times, most recently from e40ba5d to 6ef4653 Compare November 21, 2019 12:46
@pan93412
Copy link
Contributor Author

btw i don't really know how to request review...

@pan93412 pan93412 force-pushed the zh-tw-translations-191121 branch from 06aedf5 to a906a7b Compare November 21, 2019 13:28
@SEWeiTung
Copy link
Contributor

@nodejs/nodejs-tw: Please have a review.

@SEWeiTung SEWeiTung requested a review from osk2 November 23, 2019 08:26
@SEWeiTung
Copy link
Contributor

SEWeiTung commented Nov 23, 2019 •
edited
Loading

@pan93412: You should be added by someone inside @nodejs/nodejs-tw, then you can make a review request ^_^.
But consider that you are NOT a member of Nodejs group, maybe @MylesBorins or someone can add you there, then you should be also added by @nodejs/nodejs-tw.

PeterDaveHello
PeterDaveHello suggested changes Nov 23, 2019
View reviewed changes
Copy link
Member

@PeterDaveHello PeterDaveHello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Untranslated files should be removed first.

@pan93412
Copy link
Contributor Author

Wait for me.

@pan93412 pan93412 force-pushed the zh-tw-translations-191121 branch from 921189b to 7650d8e Compare November 24, 2019 05:24
@pan93412
Copy link
Contributor Author

@PeterDaveHello @MaledongGit Ok I have solved it, could you guys review again? :)

SEWeiTung
SEWeiTung reviewed Nov 24, 2019
View reviewed changes
SEWeiTung
SEWeiTung reviewed Nov 24, 2019
View reviewed changes
SEWeiTung
SEWeiTung reviewed Nov 24, 2019
View reviewed changes
SEWeiTung
SEWeiTung reviewed Nov 24, 2019
View reviewed changes
SEWeiTung
SEWeiTung reviewed Nov 24, 2019
View reviewed changes
SEWeiTung
SEWeiTung reviewed Nov 24, 2019
View reviewed changes
SEWeiTung
SEWeiTung reviewed Nov 24, 2019
View reviewed changes
SEWeiTung
SEWeiTung reviewed Nov 24, 2019
View reviewed changes
SEWeiTung
SEWeiTung reviewed Nov 24, 2019
View reviewed changes
SEWeiTung
SEWeiTung reviewed Nov 24, 2019
View reviewed changes
SEWeiTung
SEWeiTung reviewed Nov 24, 2019
View reviewed changes
SEWeiTung
SEWeiTung reviewed Nov 24, 2019
View reviewed changes
@SEWeiTung SEWeiTung changed the title l10n(zh_TW): update & improve translations zh-tw: update & improve translations Nov 24, 2019
@pan93412 pan93412 changed the title zh-tw: update & improve translations WIP(untranslated): zh-tw: update & improve translations Nov 24, 2019
osk2
osk2 reviewed Nov 24, 2019
View reviewed changes
Copy link
Contributor

@osk2 osk2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contribution. Here are some suggestions for this PR:

  1. It will be easier to review if you can separate new translations and improvements into different PR
  2. Untranslated contents are hard to read and meaningless. Remove them before they are ready

@pan93412 pan93412 requested review from SEWeiTung and osk2 November 24, 2019 10:01
osk2
osk2 suggested changes Nov 25, 2019
View reviewed changes
PeterDaveHello
PeterDaveHello reviewed Nov 25, 2019
View reviewed changes
PeterDaveHello
PeterDaveHello reviewed Nov 25, 2019
View reviewed changes
PeterDaveHello
PeterDaveHello suggested changes Nov 25, 2019
View reviewed changes
Copy link
Member

@PeterDaveHello PeterDaveHello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll suggest separate styling and wording changes into different commits, the commits history here should be reorganized.

@pan93412
l10n(zh_TW): update base
2cf25ad 
Signed-off-by: pan93412 <pan93412@gmail.com>
@pan93412
l10n(zh_TW): update & improve translations
c335121 
Signed-off-by: pan93412 <pan93412@gmail.com>
@pan93412
fix(zh_TW): remove untranslated contents
4990f6a
@pan93412 pan93412 force-pushed the zh-tw-translations-191121 branch from c9777a5 to 1f685d9 Compare November 25, 2019 15:09
@pan93412 pan93412 force-pushed the zh-tw-translations-191121 branch from 1f685d9 to 0cde8b5 Compare November 25, 2019 15:13
osk2
osk2 reviewed Nov 26, 2019
View reviewed changes
osk2
osk2 suggested changes Nov 26, 2019
View reviewed changes
@pan93412 pan93412 requested a review from osk2 November 26, 2019 10:51
osk2
osk2 approved these changes Nov 26, 2019
View reviewed changes
Copy link
Contributor

@osk2 osk2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@osk2 osk2 changed the title WIP(untranslated): zh-tw: update & improve translations zh-tw: update & improve translations Nov 26, 2019
@nschonni nschonni merged commit 9ec7d8a into nodejs:master Nov 28, 2019
This was referenced Jul 17, 2020
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PeterDaveHello PeterDaveHello Awaiting requested review from PeterDaveHello

2 more reviewers

@osk2 osk2 osk2 approved these changes

@SEWeiTung SEWeiTung SEWeiTung approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@pan93412 @SEWeiTung @osk2 @PeterDaveHello @nschonni