Update dont-block-the-event-loop.md#2479
Conversation
Added broader description on DNS.
|
This should link to Wikipedia instead of a random site... |
|
HI, @MariahWine! Welcome, and thanks for the pull request. First, I agree with @XhmikosR's comment that we ought to link to a de facto standard reference like Wikipedia or MDN instead. (I personally think the MDN definition may be the better choice here, but either one would be fine.) I'd also add that it should be at the first occurrence of the term in the document. This is not the first occurrence. The first occurrence already links to the Node.js docs for the So if we want to do this, it probably involves changing the earlier link rather than adding a link here? But I'm not sure we want to do that? The argument for doing nothing would be this: DNS is a standard and easily-searchable term so I'm not sure a link is really required here. For example, the Node.js docs for the On the other hand: It's not as if this guide has too many links or anything, so adding one here should be fine, I think. The question is finding a way to add it that doesn't introduce other issues. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Really appreciate your time while reviewing my pull request! I was studying this document with my student for a few days in a row. We both have agreed that some terms require in-depth analysis for juniors/middle to be understood for sure. I thought that this "fun-informative" balanced article would be a good match. As I'm new in Github community, my opinion may be wrong. And yes, as @Trott noticed, I've created this account particularly for this documentation, so I don't know the exact rules of contributions. Hope now my pull request looks more logical to you. |
|
@nodejs/website Thoughts on this one? I'm OK with landing it as-is if there's consensus that it's an improvement, regardless of whether or not it's ideal. I'm also OK with a "Hmmm, thanks, but I don't think we want to do this." But it would be great to get a decision, one way or the other. |
Added broader description on DNS.