Skip to content

Conversation

@JungMinu
Copy link
Member

@JungMinu JungMinu commented Oct 9, 2015

Please review this post. ❤️,@nodejs/evangelism

Please review this post. ❤️,@nodejs/evangelism
@Fishrock123
Copy link
Contributor

The releases section may already be outdated. 4.2.0 may still drop this week. See: nodejs/node#3258

@Fishrock123
Copy link
Contributor

Also I'm wondering if the releases sections are good ideas here? We already do release blog posts.

@JungMinu
Copy link
Member Author

JungMinu commented Oct 9, 2015

@Fishrock123 Thanks for your comment 😄

Also I'm wondering if the releases sections are good ideas here? We already do release blog posts.

@nodejs/evangelism What are your ideas? 😄

@mikeal
Copy link
Contributor

mikeal commented Oct 9, 2015

Some people see the weekly updates that don't see the release posts so we should at least mention that a release happened, and maybe just link to that release post, in each weekly update, but we probably don't need to go in to the detail that we were previously.

@JungMinu
Copy link
Member Author

JungMinu commented Oct 9, 2015

@Fishrock123 It seems that 4.2.0 is aiming for Monday release.
May I mention it in this weekly post?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Should be two sentences. (The comma should be a period.)

@Trott
Copy link
Member

Trott commented Oct 9, 2015

I agree that there should be less detail about the release. Just mention the release, make sure there's a link for people to get more information, and maybe mention the most important one or two things about it. Otherwise, "fixes several bugs" is a pretty good filler text for patch releases.

@Trott
Copy link
Member

Trott commented Oct 9, 2015

The news about Red Hat should have a link to the press release or something with more information. Here's one you can use: https://www.redhat.com/en/about/press-releases/red-hat-joins-nodejs-foundation

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Instead of StrongLoop introduces Arrow functions (which makes it sound like they have a Node.js feature no one else has), go with something like StrongLoop provides "An Introduction to JavaScript ES6 Arrow Functions"

@JungMinu
Copy link
Member Author

JungMinu commented Oct 9, 2015

@Trott I've updated based on your comments.

@JungMinu
Copy link
Member Author

JungMinu commented Oct 9, 2015

I wonder why CI isn't happy

@fhemberger
Copy link
Contributor

@JungMinu Travis is drunk. Don't worry.

@JungMinu
Copy link
Member Author

JungMinu commented Oct 9, 2015

@fhemberger Thanks :)

@fhemberger
Copy link
Contributor

LGTM, can we merge it?

@JungMinu
Copy link
Member Author

JungMinu commented Oct 9, 2015

I'd love to 👍

fhemberger added a commit that referenced this pull request Oct 9, 2015
@fhemberger fhemberger merged commit 324d239 into master Oct 9, 2015
@fhemberger
Copy link
Contributor

Bam! 💥 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants