-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix] Fix typo errors #1703
[Fix] Fix typo errors #1703
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This would not work in production as the server is only used for development. Not sure how useful this feature is for development. |
@lpinca: For FF and Chrome, it can read out All in all, I only check when you are accessing the root without a default language, it will try to fetch your pre-set lang from the browser (Maybe according to your localization system) and guide you to a correct website of a lang. Because I didn't change any rules but just attach dynamically lang to the root E.g: And Thanks anyway! |
@Maledong Files in production are served pre-gzipped through nginx (using We already had a discussion about this in: #806 (comment) (and even in the io.js days: nodejs/iojs.org#235) Unfortunately, there's only a 3rd party module for nginx. So this has to be addressed by the @nodejs/build team. |
/
Well thanks all! I changed my commit to fix a typo error instead. Language will be discussed with all of you later after I read your discussion first. |
[Senario]
Someone is now accessing the home page with a root path
/
( Such ashttps://nodejs.org/
):The current is now guiding you to an English page.
Now I guide you to a page where you like according to your local system language from
accept-language
, which looks better and more friendly.[Notices]
Please run
npm i
to install a 3-rd partyaccept-language
before you run or deploy this.