Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

blog: fix indentation #1425

Merged
merged 1 commit into from
Oct 26, 2017
Merged

blog: fix indentation #1425

merged 1 commit into from
Oct 26, 2017

Conversation

maclover7
Copy link
Contributor

cjihrig
cjihrig approved these changes Oct 26, 2017
View reviewed changes
Copy link
Contributor

@cjihrig cjihrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but isn't all of this auto generated?

@maclover7
Copy link
Contributor Author

Welp, turns out the issue is that the changelog in nodejs/node for v8.8.1 is indented more than it should be... who knew two spaces could cause so much trouble... This should go in, but also looks the changelog will need to be fixed as well.

@cjihrig
Copy link
Contributor

cjihrig commented Oct 26, 2017

Ah, my bad. I'm going to land this.

@cjihrig cjihrig merged commit c056fa6 into nodejs:master Oct 26, 2017
@maclover7 maclover7 mentioned this pull request Oct 26, 2017
Closed
2 tasks
@maclover7 maclover7 deleted the jm-fix-indentation branch October 26, 2017 01:03
@maclover7
Copy link
Contributor Author

no worries :) opened nodejs/node#16507 to fix this in nodejs/node

tniessen pushed a commit to nodejs/node that referenced this pull request Oct 28, 2017
@maclover7 @tniessen
doc: fix CHANGELOG_V8 indentation
737239a 
Should not be nested under the bullet point. Headings need to be at the
root level.

PR-URL: #16507
Refs: nodejs/nodejs.org#1425
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
tniessen pushed a commit to nodejs/node that referenced this pull request Oct 28, 2017
@maclover7 @tniessen
doc: add note to releases.md
6a7210e 
PR-URL: #16507
Refs: nodejs/nodejs.org#1425
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
gibfahn pushed a commit to nodejs/node that referenced this pull request Oct 30, 2017
@maclover7 @gibfahn
doc: fix CHANGELOG_V8 indentation
3f72d89 
Should not be nested under the bullet point. Headings need to be at the
root level.

PR-URL: #16507
Refs: nodejs/nodejs.org#1425
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
gibfahn pushed a commit to nodejs/node that referenced this pull request Oct 30, 2017
@maclover7 @gibfahn
doc: add note to releases.md
82068e4 
PR-URL: #16507
Refs: nodejs/nodejs.org#1425
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
gibfahn pushed a commit to nodejs/node that referenced this pull request Oct 30, 2017
@maclover7 @gibfahn
doc: fix CHANGELOG_V8 indentation
c853074 
Should not be nested under the bullet point. Headings need to be at the
root level.

PR-URL: #16507
Refs: nodejs/nodejs.org#1425
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
gibfahn pushed a commit to nodejs/node that referenced this pull request Oct 30, 2017
@maclover7 @gibfahn
doc: add note to releases.md
d4e8ac4 
PR-URL: #16507
Refs: nodejs/nodejs.org#1425
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
gibfahn pushed a commit to nodejs/node that referenced this pull request Oct 31, 2017
@maclover7 @gibfahn
doc: fix CHANGELOG_V8 indentation
03b233e 
Should not be nested under the bullet point. Headings need to be at the
root level.

PR-URL: #16507
Refs: nodejs/nodejs.org#1425
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
gibfahn pushed a commit to nodejs/node that referenced this pull request Oct 31, 2017
@maclover7 @gibfahn
doc: add note to releases.md
0460210 
PR-URL: #16507
Refs: nodejs/nodejs.org#1425
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Qard pushed a commit to ayojs/ayo that referenced this pull request Nov 2, 2017
@maclover7 @Qard
doc: fix CHANGELOG_V8 indentation
3efbb05 
Should not be nested under the bullet point. Headings need to be at the
root level.

PR-URL: nodejs/node#16507
Refs: nodejs/nodejs.org#1425
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Qard pushed a commit to ayojs/ayo that referenced this pull request Nov 2, 2017
@maclover7 @Qard
doc: add note to releases.md
a19fcc6 
PR-URL: nodejs/node#16507
Refs: nodejs/nodejs.org#1425
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Qard pushed a commit to ayojs/ayo that referenced this pull request Nov 2, 2017
@maclover7 @Qard
doc: fix CHANGELOG_V8 indentation
5afa588 
Should not be nested under the bullet point. Headings need to be at the
root level.

PR-URL: nodejs/node#16507
Refs: nodejs/nodejs.org#1425
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Qard pushed a commit to ayojs/ayo that referenced this pull request Nov 2, 2017
@maclover7 @Qard
doc: add note to releases.md
0eb3232 
PR-URL: nodejs/node#16507
Refs: nodejs/nodejs.org#1425
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
MylesBorins pushed a commit to nodejs/node that referenced this pull request Nov 16, 2017
@maclover7 @MylesBorins
doc: add note to releases.md
4d9464c 
PR-URL: #16507
Refs: nodejs/nodejs.org#1425
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
MylesBorins pushed a commit to nodejs/node that referenced this pull request Nov 21, 2017
@maclover7 @MylesBorins
doc: add note to releases.md
6032614 
PR-URL: #16507
Refs: nodejs/nodejs.org#1425
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
MylesBorins pushed a commit to nodejs/node that referenced this pull request Nov 28, 2017
@maclover7 @MylesBorins
doc: add note to releases.md
39c63da 
PR-URL: #16507
Refs: nodejs/nodejs.org#1425
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
addaleax pushed a commit to ayojs/ayo that referenced this pull request Dec 7, 2017
@maclover7 @addaleax
doc: fix CHANGELOG_V8 indentation
23316db 
Should not be nested under the bullet point. Headings need to be at the
root level.

PR-URL: nodejs/node#16507
Refs: nodejs/nodejs.org#1425
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
addaleax pushed a commit to ayojs/ayo that referenced this pull request Dec 7, 2017
@maclover7 @addaleax
doc: add note to releases.md
529d07f 
PR-URL: nodejs/node#16507
Refs: nodejs/nodejs.org#1425
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maclover7 @cjihrig