Merge pull request #67 from phillipj/improve-load-versions

Improve error message and exit code in load-versions.js

Author: mikeal

load-versions.js

@@ -4,24 +4,26 @@
 
 const fs = require('fs');
 const semver = require('semver')
-
+const https = require('https');
 
 function download (url, cb) {
     let data = '';
-    const request = require('https').get(url, function (res) {
-
+    https.get(url, function (res) {
         res.on('data', function (chunk) { data += chunk; });
         res.on('end', function () { cb(null, data); });
-    });
-
-    request.on('error', function (e) {
-        console.error('Error downloading file:', e.message);
-        cb(e.message);
+    }).on('error', function (e) {
+        console.error('Error downloading file from %s: %s', url, e.message);
+        cb(e);
     });
 }
 
-download('https://new.nodejs.org/dist/index.json', function (err, nodeVersions) {
-    download('https://iojs.org/dist/index.json', function (err, iojsVersions) {
+download('https://new.nodejs.org/dist/index.json', function (nodeErr, nodeVersions) {
+    download('https://iojs.org/dist/index.json', function (iojsErr, iojsVersions) {
+
+        if (nodeErr || iojsErr) {
+            console.error('Aborting due to download error from node or iojs');
+            return process.exit(1);
+        }
 
         let allVersions = [];
         try {
@@ -31,6 +33,7 @@ download('https://new.nodejs.org/dist/index.json', function (err, nodeVersions)
             allVersions = nodeVersions.concat(iojsVersions);
         } catch(e) {
             console.error('Error parsing json', e);
+            return process.exit(1);
         }
 
         allVersions.sort(function (a, b) {