Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: use strictEqual instead of equal #9930

Closed
wants to merge 1 commit into from
Closed

test: use strictEqual instead of equal #9930

wants to merge 1 commit into from

Conversation

kingnebby
Copy link
Contributor

Checklist
  • make -j8 test (UNIX)
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

Description of change

Updated test to remove error since expectation is to use strictEquals
for tests.

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Dec 1, 2016
@imyller imyller added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Dec 1, 2016
@mscdex mscdex added the child_process Issues and PRs related to the child_process subsystem. label Dec 1, 2016
princejwesley
princejwesley approved these changes Dec 1, 2016
View reviewed changes
Copy link
Contributor

@princejwesley princejwesley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change first line of commit message as test: refactor test-child-process-double-pipe
and specify the change description in the next line.

@kingnebby
test: refactor test-child-process-double-pipe
ef77bb6 
Update test to use strictEqual instead of equal to remove error.
addaleax
addaleax approved these changes Dec 5, 2016
View reviewed changes
Copy link
Member

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI: https://ci.nodejs.org/job/node-test-commit/6406/

jasnell pushed a commit that referenced this pull request Dec 5, 2016
@kingnebby @jasnell
test: refactor test-child-process-double-pipe
a6ab607 
Update test to use strictEqual instead of equal to remove error.

PR-URL: #9930
Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell
Copy link
Member

jasnell commented Dec 5, 2016

Landed in a6ab607. thank you for the PR and for participating in the code-and-learn!

@jasnell jasnell closed this Dec 5, 2016
Fishrock123 pushed a commit that referenced this pull request Dec 6, 2016
@kingnebby @Fishrock123
test: refactor test-child-process-double-pipe
2beba9e 
Update test to use strictEqual instead of equal to remove error.

PR-URL: #9930
Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax pushed a commit to addaleax/node that referenced this pull request Dec 8, 2016
@kingnebby @addaleax
test: refactor test-child-process-double-pipe
b71d3fd 
Update test to use strictEqual instead of equal to remove error.

PR-URL: nodejs#9930
Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
jmdarling pushed a commit to jmdarling/node that referenced this pull request Dec 8, 2016
@kingnebby
test: refactor test-child-process-double-pipe
4342145 
Update test to use strictEqual instead of equal to remove error.

PR-URL: nodejs#9930
Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 20, 2016
@kingnebby @MylesBorins
test: refactor test-child-process-double-pipe
70b4d7d 
Update test to use strictEqual instead of equal to remove error.

PR-URL: #9930
Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
@kingnebby @MylesBorins
test: refactor test-child-process-double-pipe
1523b5c 
Update test to use strictEqual instead of equal to remove error.

PR-URL: #9930
Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
@kingnebby @MylesBorins
test: refactor test-child-process-double-pipe
24faf12 
Update test to use strictEqual instead of equal to remove error.

PR-URL: #9930
Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced Dec 21, 2016
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@princejwesley princejwesley princejwesley approved these changes

@addaleax addaleax addaleax approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
child_process Issues and PRs related to the child_process subsystem. code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@kingnebby @jasnell @addaleax @princejwesley @cjihrig @mscdex @MylesBorins @imyller @nodejs-github-bot