backport: http: fix connection upgrade checks#9681
Closed
mscdex wants to merge 1 commit intonodejs:v4.x-stagingfrom
Closed
backport: http: fix connection upgrade checks#9681mscdex wants to merge 1 commit intonodejs:v4.x-stagingfrom
mscdex wants to merge 1 commit intonodejs:v4.x-stagingfrom
Conversation
This commit fixes connection upgrade checks, specifically when headers are passed as an array instead of a plain object to http.request() Fixes: nodejs#8235 PR-URL: nodejs#8238 Reviewed-By: James M Snell <jasnell@gmail.com>
3 tasks
MylesBorins
approved these changes
Nov 18, 2016
Contributor
MylesBorins
left a comment
MylesBorins
left a comment
There was a problem hiding this comment.
rubber stamp LGTM if CI is green
Contributor
Author
|
I'm not sure what's up with the freebsd11 node failure, it looks like it has an old compiler installed or something? OS X tty test failure is unrelated. |
Contributor
|
it hasn't ever been working on v4 just been rolling with it On Fri, Nov 18, 2016, 3:38 PM Brian White notifications@github.com wrote:
|
Contributor
Contributor
|
looking good |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j8 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
Description of change
This commit fixes connection upgrade checks, specifically when headers are passed as an array instead of a plain object to
http.request().This is a backport of #8238.
CI: https://ci.nodejs.org/job/node-test-pull-request/4894/