Skip to content

Conversation

@Trott
Copy link
Member

@Trott Trott commented Nov 5, 2016

Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test debugger

Description of change

test-debug-signal-cluster contains a watchdog timer that results in
false positives in CI. Remove the watchdog timer and let the test runner
determine that the test has timed out.

Example failure: https://ci.nodejs.org/job/node-test-commit-smartos/5075/nodes=smartos14-64/console

not ok 217 parallel/test-debug-signal-cluster
# got pids [81560,84923,85367]
# 
# assert.js:85
#   throw new assert.AssertionError({
#   ^
# AssertionError: test timed out
#     at Object.exports.fail (/home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos14-64/test/common.js:443:10)
#     at Timeout.testTimedOut [as _onTimeout] (/home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos14-64/test/parallel/test-debug-signal-cluster.js:69:10)
#     at ontimeout (timers.js:365:14)
#     at Timer.unrefdHandle (timers.js:466:3)
# > all workers are running
# > Starting debugger agent.
# > Debugger listening on 127.0.0.1:12646
# > Starting debugger agent.
  ---
  duration_ms: 7.124

CI stress test on current master showing failures: https://ci.nodejs.org/job/node-stress-single-test/1053/nodes=smartos14-64/console

CI stress test on this change (will hopefully come up green): https://ci.nodejs.org/job/node-stress-single-test/1054/nodes=smartos14-64/console

test-debug-signal-cluster contains a watchdog timer that results in
false positives in CI. Remove the watchdog timer and let the test runner
determine that the test has timed out.
@Trott Trott added debugger test Issues and PRs related to the tests. labels Nov 5, 2016
@Trott
Copy link
Member Author

Trott commented Nov 7, 2016

Trott added a commit to Trott/io.js that referenced this pull request Nov 8, 2016
test-debug-signal-cluster contains a watchdog timer that results in
false positives in CI. Remove the watchdog timer and let the test runner
determine that the test has timed out.

PR-URL: nodejs#9476
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@Trott
Copy link
Member Author

Trott commented Nov 8, 2016

Landed in b0486b1

@Trott Trott closed this Nov 8, 2016
addaleax pushed a commit that referenced this pull request Nov 22, 2016
test-debug-signal-cluster contains a watchdog timer that results in
false positives in CI. Remove the watchdog timer and let the test runner
determine that the test has timed out.

PR-URL: #9476
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 1, 2016
test-debug-signal-cluster contains a watchdog timer that results in
false positives in CI. Remove the watchdog timer and let the test runner
determine that the test has timed out.

PR-URL: #9476
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 1, 2016
test-debug-signal-cluster contains a watchdog timer that results in
false positives in CI. Remove the watchdog timer and let the test runner
determine that the test has timed out.

PR-URL: #9476
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced Dec 1, 2016
@Trott Trott deleted the signal-cluster branch January 13, 2022 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test Issues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants