zlib: name every function #9389
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasnell
reviewed
Nov 2, 2016
lib/zlib.js
Outdated
| var self = this; | ||
| this._hadError = false; | ||
| this._handle.onerror = function(message, errno) { | ||
| this._handle.onerror = (message, errno) => { |
Member
There was a problem hiding this comment.
I wouldn't change this one to an arrow function. There's really no point in doing so here. I would just add a name to the existing function
jasnell
approved these changes
Nov 3, 2016
silverwind
approved these changes
Nov 3, 2016
Contributor
Author
|
no CI? |
Contributor
Contributor
Author
|
@silverwind boink? |
Member
|
Failure on arm in CI looks un-related so should be good to land |
Member
|
Landed as 77ec310 |
mhdawson
pushed a commit
that referenced
this pull request
Nov 8, 2016
PR-URL: #9389 Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Member
|
This has broken linting on CI because it violates a lint rule that landed since CI was run for it 5 days ago. :-( |
2 tasks
Member
|
The fix is at #9524. |
addaleax
pushed a commit
that referenced
this pull request
Nov 22, 2016
PR-URL: #9389 Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
MylesBorins
added
the
baking-for-lts
MylesBorins
added
dont-land-on-v6.x
and removed
baking-for-lts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j8 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
zlib
Description of change
named handlers
Ref: #8913