Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: clean up dgram-broadcast-multi-process test #9308

Closed
wants to merge 1 commit into from
Closed

test: clean up dgram-broadcast-multi-process test #9308

wants to merge 1 commit into from

Conversation

iredelmeier
Copy link
Contributor

Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

Description of change

Use assert.strictEqual() instead of assert.equal(), === instead of ==, and const instead of var.

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Oct 27, 2016
Use assert.strictEqual() instead of assert.equal(),
=== instead of ==, and const instead of var.
@Trott
Copy link
Member

Trott commented Oct 27, 2016

LGTM

Not running full CI because internet tests don't get run in CI. Ran locally and was fine. Ran make jslint and it came up clean too.

Linter job on CI: https://ci.nodejs.org/job/node-test-linter/5014/

@mscdex mscdex added the dgram Issues and PRs related to the dgram subsystem / UDP. label Oct 27, 2016
Copy link
Member

@bengl bengl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Trott pushed a commit to Trott/io.js that referenced this pull request Oct 29, 2016
Use assert.strictEqual() instead of assert.equal(),
=== instead of ==, and const instead of var.

PR-URL: nodejs#9308
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Bryan English <bryan@bryanenglish.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@Trott
Copy link
Member

Trott commented Oct 29, 2016

Landed in b9f6a2d. Thanks!

@Trott Trott closed this Oct 29, 2016
evanlucas pushed a commit that referenced this pull request Nov 3, 2016
Use assert.strictEqual() instead of assert.equal(),
=== instead of ==, and const instead of var.

PR-URL: #9308
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Bryan English <bryan@bryanenglish.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Nov 22, 2016
Use assert.strictEqual() instead of assert.equal(),
=== instead of ==, and const instead of var.

PR-URL: #9308
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Bryan English <bryan@bryanenglish.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Nov 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dgram Issues and PRs related to the dgram subsystem / UDP. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants