os: name every function OS module

[lprasanthi]

Checklist

• make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
• commit message follows commit guidelines

Affected core subsystem(s)

os

Description of change

There are too many anonymous functions in the source code which makes heap debugging frustrating.
Naming functions in os module as part of this issue

[lprasanthi]

@thefourtheye

[thefourtheye]

@lprasanthi Can you please change the commit message, as per these guidelines?

[thefourtheye]

CI Run: https://ci.nodejs.org/job/node-test-pull-request/4630/

[princejwesley]

LGTM

[pvsousalima]

In my pull requests the same type of tests are failing when they go to CI Run: #9225 #9217

[imyller]

LGTM

[Trott]

Thanks for the PR, but I'm afraid I'm opposed to this as it changes the code for no benefit.

Relevant stack trace line before:

 at Object.exports.arch (os.js:27:9)

..and with this change:

at Object.arch (os.js:27:9)

I'm not seeing the benefit here. Sorry.

If you want to find anonymous functions where naming them will improve the stack trace, look for code like this:

some.functionCall(arg1, arg2, function() {
  //this function needs a name
});

[Trott]

Actually, I suspect this can be salvaged by creating an object in the module named os (or, at least, OS?) and exporting the object. Change all the exports.arch = function... stuff to os.arch = function... and BOOM instant better stack traces (I think--I haven't, you know, actually tested this theory).

[Fishrock123]

@Trott this is about heap snapshots and such, not stacktraces.

[Trott]

If I'm not mistaken, the same issue applies to heap snapshots.

os.arch currently appears as exports.arch in heap snapshots like this:

With the change here, it will appear as simply arch:

My understanding of how to read heap snapshots in Chrome Dev Tools is limited, so I may be missing something. Corrections are welcome. But if I'm not completely off base here, then I would think at least that my suggestion in #9250 (comment) is more the way to go.

[silverwind]

@Trott any idea on how to remove the Object. prefix? It shows with

mod=exports;
mod.fn = () => console.trace();
fn();

but curiously, not when immediatly invoked:

mod=exports;
(mod.fn = () => console.trace())();

[Trott]

@silverwind Not sure, actually. Haven't had time to look too closely, but if someone else knows or figures it out, please post here. :-D

[jasnell]

Any updates on this?

[fhinkel]

There hasn't been any activity here. I'm closing this. Feel free to reopen (or ping a collaborator) if I closed this in error.