Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add IntelliJ project file+directory to .gitignore #9111

Closed
wants to merge 1 commit into from
Closed

add IntelliJ project file+directory to .gitignore #9111

wants to merge 1 commit into from

Conversation

kribblo
Copy link

@kribblo kribblo commented Oct 15, 2016

Checklist
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

Add IntelliJ idea project files to .gitignore, much as other IDE files are ignored.

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Oct 15, 2016
@richardlau
Copy link
Member

Related #8016 ?

@fhinkel
Copy link
Member

fhinkel commented Oct 16, 2016

Thanks for the PR. But with the fix in #8016, files in .idea are also ignored.

I'll close this in favor of #8016. Feel free to reopen if you feel it should be a separate PR.

@fhinkel fhinkel closed this Oct 16, 2016
Fishrock123 pushed a commit that referenced this pull request Dec 5, 2016
Instead of excluding IDE-specific dotfiles, exclude all and
then whitelist those the project needs to track.

Refs: #8010
Refs: #9111
Refs: #10052

Fixes: #8012
PR-URL: #8016

Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Josh Gavant <josh.gavant@outlook.com>
addaleax pushed a commit that referenced this pull request Dec 5, 2016
Instead of excluding IDE-specific dotfiles, exclude all and
then whitelist those the project needs to track.

Refs: #8010
Refs: #9111
Refs: #10052

Fixes: #8012
PR-URL: #8016

Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Josh Gavant <josh.gavant@outlook.com>
jmdarling pushed a commit to jmdarling/node that referenced this pull request Dec 8, 2016
Instead of excluding IDE-specific dotfiles, exclude all and
then whitelist those the project needs to track.

Refs: nodejs#8010
Refs: nodejs#9111
Refs: nodejs#10052

Fixes: nodejs#8012
PR-URL: nodejs#8016

Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Josh Gavant <josh.gavant@outlook.com>
MylesBorins pushed a commit that referenced this pull request Dec 20, 2016
Instead of excluding IDE-specific dotfiles, exclude all and
then whitelist those the project needs to track.

Refs: #8010
Refs: #9111
Refs: #10052

Fixes: #8012
PR-URL: #8016

Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Josh Gavant <josh.gavant@outlook.com>
MylesBorins pushed a commit that referenced this pull request Dec 20, 2016
Instead of excluding IDE-specific dotfiles, exclude all and
then whitelist those the project needs to track.

Refs: #8010
Refs: #9111
Refs: #10052

Fixes: #8012
PR-URL: #8016

Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Josh Gavant <josh.gavant@outlook.com>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
Instead of excluding IDE-specific dotfiles, exclude all and
then whitelist those the project needs to track.

Refs: #8010
Refs: #9111
Refs: #10052

Fixes: #8012
PR-URL: #8016

Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Josh Gavant <josh.gavant@outlook.com>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
Instead of excluding IDE-specific dotfiles, exclude all and
then whitelist those the project needs to track.

Refs: #8010
Refs: #9111
Refs: #10052

Fixes: #8012
PR-URL: #8016

Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Josh Gavant <josh.gavant@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta Issues and PRs related to the general management of the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants