http: name anonymous functions in _http_client #9058
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
targos
reviewed
Oct 12, 2016
| if (this.socket) | ||
| this.socket.destroy(error); | ||
| }; | ||
|
|
||
|
|
||
| IncomingMessage.prototype._addHeaderLines = function(headers, n) { | ||
| IncomingMessage.prototype._addHeaderLines = function _addHeaderLines(headers, n) { |
There was a problem hiding this comment.
Please make sure the lines don't exceed 80 characters. make jslint should help you spot the long lines.
There was a problem hiding this comment.
this is a silly question, but I want to keep the style, should I do
IncomingMessage.prototype._addHeaderLines =
function _addHeaderLines(headers, n) {...};or
function _addHeaderLines(headers, n) {...}
IncomingMessage.prototype._addHeaderLines = _addHeaderLines;
This was referenced Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description of change
Ref: #8913