Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make tests more clear #8999

Closed
wants to merge 8 commits into from
Closed

Make tests more clear #8999

wants to merge 8 commits into from

Commits on Sep 25, 2016

  1. replace ==, !=, some instances of var, and assert.equal()

    Jenna Vuong authored Sep 25, 2016
    Configuration menu
    Copy the full SHA
    af9e4d0 View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2016

  1. change var to const

    Jenna Vuong authored Oct 10, 2016
    Configuration menu
    Copy the full SHA
    f04c78c View commit details
    Browse the repository at this point in the history

  2. change 'var' to 'const' for clarity

    Jenna Vuong authored Oct 10, 2016
    Configuration menu
    Copy the full SHA
    3d27c89 View commit details
    Browse the repository at this point in the history

  3. trying to complete git pull upstream master

    @jennabelle
    jennabelle committed Oct 10, 2016
    Configuration menu
    Copy the full SHA
    055e479 View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2016

  1. completing merge

    @jennabelle
    jennabelle committed Oct 11, 2016
    Configuration menu
    Copy the full SHA
    95b1fcd View commit details
    Browse the repository at this point in the history

  2. Change last var to const, add assert.strictEqual() 

    Add `assert.strictEqual(err.code, 'ENOENT')` and changed the last `var` to `const` for clarity
    Jenna Vuong authored Oct 11, 2016
    Configuration menu
    Copy the full SHA
    be11d1a View commit details
    Browse the repository at this point in the history

  3. add semicolon after assert.strictEqual()

    Jenna Vuong authored Oct 11, 2016
    Configuration menu
    Copy the full SHA
    393a059 View commit details
    Browse the repository at this point in the history

  4. Refactor for readability and change var to const 

    Refactor line 79 to use `includes()` instead of `indexOf() >= 0` for better readability. Change `var` to `const` for clarity
    Jenna Vuong authored Oct 11, 2016
    Configuration menu
    Copy the full SHA
    e02413c View commit details
    Browse the repository at this point in the history