Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add CTC meeting minutes 2016-08-31 #8424

Merged
merged 1 commit into from
Sep 12, 2016

Conversation

joshgav
Copy link
Contributor

@joshgav joshgav commented Sep 6, 2016

Checklist
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

Description of change

/cc @nodejs/ctc

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Sep 6, 2016
@jasnell
Copy link
Member

jasnell commented Sep 6, 2016

LGTM


@trott: In the issue I see only supportive voices. Any questions or concerns?

@Fishrock123: Chris (Dickinson?) did some work on making an indexer that could track code paths (?). Just an aside, it’d be nice to get his opinion.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, Dickinson.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed. LGTY?

@Trott
Copy link
Member

Trott commented Sep 7, 2016

LGTM

PR-URL: nodejs#8424
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@joshgav joshgav merged commit f1629e7 into nodejs:master Sep 12, 2016
@joshgav
Copy link
Contributor Author

joshgav commented Sep 12, 2016

landed in f1629e7

Fishrock123 pushed a commit that referenced this pull request Sep 14, 2016
PR-URL: #8424
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins pushed a commit that referenced this pull request Sep 30, 2016
PR-URL: #8424
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins pushed a commit that referenced this pull request Oct 10, 2016
PR-URL: #8424
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
rvagg pushed a commit that referenced this pull request Oct 18, 2016
PR-URL: #8424
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins pushed a commit that referenced this pull request Oct 26, 2016
PR-URL: #8424
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Oct 26, 2016
@joshgav joshgav deleted the ctc-2016-08-31 branch October 27, 2016 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants