src: update f function call comment #8416
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit a01e8bc moved a comment to be closer to the place in the code it was describing. While working on this there was feedback on the comment itself: https://github.com/nodejs/node/commit/ a01e8bc#comments This PR includes the suggestions in the above comments.
mscdex
added
the
c++
|
LGTM |
|
LGTM I suppose? |
|
LGTM. |
|
LGTM. I'd say this is minor enough that it doesn't need to wait the 48 hours. |
|
Nit: commit title should use the imperative tense |
|
@targos Thanks for pointing this out. I'll update the commit title and adhere to this in the future. |
danbev
changed the title
|
Landed in 8afde12 |
danbev
added a commit
that referenced
this pull request
Sep 7, 2016
Commit a01e8bc (src: moving f function call comment, 2016-09-04) moved a comment to be closer to the place in the code it was describing. While working on this there was feedback on the comment itself: https://github.com/nodejs/node/commit/ a01e8bc#comments This PR includes the suggestions in the above comments. PR-URL: #8416 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Franziska Hinkelmann <franzih@chromium.org> Reviewed-By: James M Snell <jasnell@gmail.com>
Fishrock123
pushed a commit
that referenced
this pull request
Sep 14, 2016
Commit a01e8bc (src: moving f function call comment, 2016-09-04) moved a comment to be closer to the place in the code it was describing. While working on this there was feedback on the comment itself: https://github.com/nodejs/node/commit/ a01e8bc#comments This PR includes the suggestions in the above comments. PR-URL: #8416 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Franziska Hinkelmann <franzih@chromium.org> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
src
Description of change
Commit a01e8bc moved a comment to be closer to the place in the code it
was describing. While working on this there was feedback on the comment
itself.
This PR includes the suggestions in the above comments.