build: don't require processing docs for nightlies #8325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
build
|
LGTM |
|
LGTM |
1 similar comment
|
LGTM |
| @@ -460,7 +460,7 @@ PACKAGEMAKER ?= /Developer/Applications/Utilities/PackageMaker.app/Contents/MacO | |||
| PKGDIR=out/dist-osx | |||
|
|
|||
| release-only: | |||
| @if `grep -q REPLACEME doc/api/*.md`; then \ | |||
| @if [ "$(DISTTYPE)" = "release" ] && [ `grep -q REPLACEME doc/api/*.md` ]; then \ | |||
There was a problem hiding this comment.
I think it might be better to check that DISTTYPE is not nightly or next-nightly. If it's set to "custom", you presumably still want this check.
(Also, opting out is arguably better than opting in when it comes to quality checks.)
There was a problem hiding this comment.
Happy to change -- I agree with opt-out but please elaborate on a use case when custom would benefit from the check!
There was a problem hiding this comment.
It's based on the assumption that people use it for internal releases. We do that at IBM although I don't know if we use this particular mechanism.
There was a problem hiding this comment.
Ok. I'll make a note in the commit msg.
|
Failures unrelated. I've tested with |
|
LGTM if you add a line or two to the commit log. Right now it's just a one-liner. |
Opt-out `nightly` and `next-nightly` from the documentation requirement since these docs aren't meant to be published. This fixes our nightly jobs in CI. PR-URL: nodejs#8325 Fixes: nodejs/build#478 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
jbergstroem
force-pushed
the
fix/nightly-skip-apidoc
branch
from
a186944
to
2168432
Compare
|
Commit message validation: https://ci.nodejs.org/job/node-test-commitmsg/16/tapResults/ |
Closed
Fishrock123
pushed a commit
to Fishrock123/node
that referenced
this pull request
Sep 8, 2016
Opt-out `nightly` and `next-nightly` from the documentation requirement since these docs aren't meant to be published. This fixes our nightly jobs in CI. PR-URL: nodejs#8325 Fixes: nodejs/build#478 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Fishrock123
pushed a commit
that referenced
this pull request
Sep 9, 2016
Opt-out `nightly` and `next-nightly` from the documentation requirement since these docs aren't meant to be published. This fixes our nightly jobs in CI. PR-URL: #8325 Fixes: nodejs/build#478 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
|
@jbergstroem I've backported to v4.x-staging. Let me know if it shouldn't have been |
MylesBorins
pushed a commit
that referenced
this pull request
Sep 30, 2016
Opt-out `nightly` and `next-nightly` from the documentation requirement since these docs aren't meant to be published. This fixes our nightly jobs in CI. PR-URL: #8325 Fixes: nodejs/build#478 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
|
@thealphanerd sgtm. |
MylesBorins
pushed a commit
that referenced
this pull request
Oct 10, 2016
Opt-out `nightly` and `next-nightly` from the documentation requirement since these docs aren't meant to be published. This fixes our nightly jobs in CI. PR-URL: #8325 Fixes: nodejs/build#478 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
rvagg
pushed a commit
that referenced
this pull request
Oct 18, 2016
Opt-out `nightly` and `next-nightly` from the documentation requirement since these docs aren't meant to be published. This fixes our nightly jobs in CI. PR-URL: #8325 Fixes: nodejs/build#478 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
MylesBorins
pushed a commit
that referenced
this pull request
Oct 26, 2016
Opt-out `nightly` and `next-nightly` from the documentation requirement since these docs aren't meant to be published. This fixes our nightly jobs in CI. PR-URL: #8325 Fixes: nodejs/build#478 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Closed
rvagg
added a commit
to rvagg/io.js
that referenced
this pull request
Nov 23, 2018
rvagg
added a commit
that referenced
this pull request
Nov 28, 2018
rvagg
added a commit
that referenced
this pull request
Nov 28, 2018
rvagg
added a commit
that referenced
this pull request
Nov 28, 2018
rvagg
added a commit
that referenced
this pull request
Nov 28, 2018
rvagg
added a commit
that referenced
this pull request
Nov 28, 2018
MylesBorins
pushed a commit
that referenced
this pull request
Nov 29, 2018
MylesBorins
pushed a commit
that referenced
this pull request
Dec 3, 2018
MylesBorins
pushed a commit
that referenced
this pull request
Dec 26, 2018
refack
pushed a commit
to refack/node
that referenced
this pull request
Jan 14, 2019
PR-URL: nodejs#24575 Refs: nodejs#24551 Refs: nodejs#12958 Refs: nodejs#12957 Refs: nodejs#8325 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
rvagg
added a commit
that referenced
this pull request
Feb 28, 2019
BethGriggs
pushed a commit
that referenced
this pull request
Mar 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
build
Description of change
Our nightlies were experiencing issues since we didn't properly replace version info in documentation (#6864). Skip that check unless we're actually doing release builds.
/cc @mhdawson, @williamkapke (reporter), @bnoordhuis, @addaleax