Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] deps: upgrade libuv to 1.10.0 #8280

Closed
wants to merge 1 commit into from
Closed

[WIP] deps: upgrade libuv to 1.10.0 #8280

wants to merge 1 commit into from

Conversation

saghul
Copy link
Member

@saghul saghul commented Aug 26, 2016

We are planning to release libuv 1.10.0 late next week, this is a placeholder for the update PR, to see if smoke comes out. A few more commits will land before we cut the release.

/cc @cjihrig

@nodejs-github-bot nodejs-github-bot added the libuv Issues and PRs related to the libuv dependency or the uv binding. label Aug 26, 2016
@addaleax addaleax added the wip Issues and PRs that are still a work in progress. label Aug 26, 2016
@saghul
Copy link
Member Author

saghul commented Aug 26, 2016

CI: https://ci.nodejs.org/job/node-test-commit/4780/

@Fishrock123
Copy link
Contributor

CITGM: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/372/ (I think I have it right..)

@saghul
Copy link
Member Author

saghul commented Aug 26, 2016

I spotted a problem on Windows. A PR will land shortly so I'll update this.

@saghul
Copy link
Member Author

saghul commented Aug 27, 2016

Updated to fix the Windows build issue. Jenkins seems to be away for the weekend, I'll try to run a CI later.

@jbergstroem
Copy link
Member

New CI: https://ci.nodejs.org/job/node-test-commit/4811/

@saghul
Copy link
Member Author

saghul commented Aug 29, 2016

CI is green except some RPi binary tests where Jenkins failed to mkdir for some reason.

CITGM: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/374/ (hopefully I started this one right)

@cjihrig
Copy link
Contributor

cjihrig commented Sep 13, 2016

Fixes #4351 per #4351 (comment)

@ronkorving
Copy link
Contributor

Can this land before Node 7?

@saghul
Copy link
Member Author

saghul commented Sep 21, 2016

I don't know, when does Node 7 land?

@ronkorving
Copy link
Contributor

ronkorving commented Sep 21, 2016 •
edited
Loading

https://github.com/nodejs/node/milestone/15 seems to indicate a code freeze on September 30? Maybe @rvagg or @jasnell can give more details?

@targos targos added this to the 7.0.0 milestone Sep 21, 2016
@targos
Copy link
Member

targos commented Sep 21, 2016

Adding to the 7.0.0 milestone so we don't forget about it.

@jasnell
Copy link
Member

jasnell commented Sep 21, 2016

The v7.x branch has already been cut. Anything that is semver-patch or semver-minor will be pulled over. Anything semver-major will require CTC review and approval to land in v7.x at this point. The first beta build will be going out today.

v7.0.0 is targeted for mid to late October depending largely on when V8 5.4 goes stable, so there's still a short amount of time (but not a lot)

@saghul
Copy link
Member Author

saghul commented Sep 21, 2016

@jasnell Ack. At the moment we are waiting on a patch to finalize z/OS support, other than that the release is ready.

@saghul
Copy link
Member Author

saghul commented Sep 23, 2016

Updated the PR with latest v1.x. Can someone help kick off a CITGM? Thanks!

@evanlucas
Copy link
Contributor

CITGM: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/394/

@saghul
Copy link
Member Author

saghul commented Sep 23, 2016

Thanks Evan!

@seishun
Copy link
Contributor

seishun commented Oct 2, 2016

I can confirm that this fixes #6763.

@Fishrock123
Copy link
Contributor

@saghul anything in here that needs to land in v7 specifically, or is this good for many minor / patch version?

@cjihrig
Copy link
Contributor

cjihrig commented Oct 5, 2016

Note, the release hasn't actually happened yet. It is still waiting on libuv/libuv#1037.

@addaleax addaleax mentioned this pull request Oct 6, 2016
Closed
2 tasks
@jasnell
Copy link
Member

jasnell commented Oct 17, 2016

@saghul ... ping... what's the status on this? Should this still be on the v7 milestone? Note that we're a week out from the actual 7.0.0 release.

@seishun
Copy link
Contributor

seishun commented Oct 17, 2016

If the libuv upgrade doesn't make into 7.0.0, when would the next window for that be?

@jasnell
Copy link
Member

jasnell commented Oct 17, 2016

that depends on how significant the update will be. If it can be landed as a semver-minor, then it can land any time within v7.x after v7.0.0 is released. If it must be landed as a semver-major, it won't go into a release until next April

@saghul
Copy link
Member Author

saghul commented Oct 17, 2016

I should be a semver minor, v1x maintains backwards compatibility.

The status is we are waiting for some final issues to be ironed out in the
z/OS PR so it can land. I may try to push for a release before the end of
the week because then I'll go missing for a bit. Colin will take this over
most likely in that case.

On Oct 17, 2016 20:07, "James M Snell" notifications@github.com wrote:

that depends on how significant the update will be. If it can be landed as
a semver-minor, then it can land any time within v7.x after v7.0.0 is
released. If it must be landed as a semver-major, it won't go into a
release until next April

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#8280 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AATYGOHZE_PXqHQejwRp4ciQ-BgTC0oNks5q07l0gaJpZM4Jt7P0
.

@rvagg rvagg force-pushed the master branch 2 times, most recently from c133999 to 83c7a88 Compare October 18, 2016 17:02
@jasnell
Copy link
Member

jasnell commented Oct 18, 2016

Ok, then I'm going to take this off the v7 milestone critical path. If it lands, great, if not, then it can go into a 7.x minor.

@jasnell jasnell removed this from the 7.0.0 milestone Oct 18, 2016
@cjihrig
Copy link
Contributor

cjihrig commented Oct 24, 2016

I'll be sending a replacement PR for this soon.

@cjihrig cjihrig closed this Oct 24, 2016
@cjihrig cjihrig removed the wip Issues and PRs that are still a work in progress. label Oct 24, 2016
@cjihrig cjihrig mentioned this pull request Oct 25, 2016
Merged
2 tasks
cjihrig added a commit to cjihrig/node that referenced this pull request Oct 26, 2016
@cjihrig
deps: upgrade libuv to 1.10.0
63243bc 
Fixes: nodejs#4351
Fixes: nodejs#6763
Refs: nodejs#8280
PR-URL: nodejs#9267
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
evanlucas pushed a commit that referenced this pull request Nov 3, 2016
@cjihrig @evanlucas
deps: upgrade libuv to 1.10.0
106d719 
Fixes: #4351
Fixes: #6763
Refs: #8280
PR-URL: #9267
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request May 16, 2017
@cjihrig @MylesBorins
deps: upgrade libuv to 1.10.0
2a06752 
Fixes: #4351
Fixes: #6763
Refs: #8280
PR-URL: #9267
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request May 18, 2017
@cjihrig @MylesBorins
deps: upgrade libuv to 1.10.0
3585ffa 
Fixes: #4351
Fixes: #6763
Refs: #8280
PR-URL: #9267
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
andrew749 pushed a commit to michielbaird/node that referenced this pull request Jul 19, 2017
@cjihrig @andrew749
deps: upgrade libuv to 1.10.0
81dc03d 
Fixes: nodejs/node#4351
Fixes: nodejs/node#6763
Refs: nodejs/node#8280
PR-URL: nodejs/node#9267
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
libuv Issues and PRs related to the libuv dependency or the uv binding.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.