gitignore: add .idea folder to .gitignore #8010
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Covers JetBrains IDEs: IntelliJ, AppCode, PyCharm, CLion, Android Studio, Webstorm and others Signed-off-by: Ilkka Myller <ilkka.myller@nodefield.com>
nodejs-github-bot
added
the
meta
|
LGTM |
|
That's why I would have rejected #7967 - accept one, gotta accept 'em all... |
|
-1. This can (and should) be handled by global |
|
See #8012 for a better approach. |
|
I'd also prefer the whitelisting approach of There are probably dozens of different development tools being used with Node.js core codebase. Until now, for some reason, Visual Studio has been the only one getting proper .gitignore definitions. Only thing I can say as defence for this PR is that it covers all of the development tools available from JetBrains. Therefore it has potential to be useful for wider audience. Adding your own IDE in global .gitignore is doable - as mentioned by @vkurchatkin - but it causes unwanted side-effects for people working with mix of private and public software projects. |
|
This PR can be closed if PR #8016 offering much better solution gets accepted. |
|
Closing in favor of #8016 |
Fishrock123
pushed a commit
that referenced
this pull request
Dec 5, 2016
Instead of excluding IDE-specific dotfiles, exclude all and then whitelist those the project needs to track. Refs: #8010 Refs: #9111 Refs: #10052 Fixes: #8012 PR-URL: #8016 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Josh Gavant <josh.gavant@outlook.com>
addaleax
pushed a commit
that referenced
this pull request
Dec 5, 2016
Instead of excluding IDE-specific dotfiles, exclude all and then whitelist those the project needs to track. Refs: #8010 Refs: #9111 Refs: #10052 Fixes: #8012 PR-URL: #8016 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Josh Gavant <josh.gavant@outlook.com>
jmdarling
pushed a commit
to jmdarling/node
that referenced
this pull request
Dec 8, 2016
Instead of excluding IDE-specific dotfiles, exclude all and then whitelist those the project needs to track. Refs: nodejs#8010 Refs: nodejs#9111 Refs: nodejs#10052 Fixes: nodejs#8012 PR-URL: nodejs#8016 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Josh Gavant <josh.gavant@outlook.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 20, 2016
Instead of excluding IDE-specific dotfiles, exclude all and then whitelist those the project needs to track. Refs: #8010 Refs: #9111 Refs: #10052 Fixes: #8012 PR-URL: #8016 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Josh Gavant <josh.gavant@outlook.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 20, 2016
Instead of excluding IDE-specific dotfiles, exclude all and then whitelist those the project needs to track. Refs: #8010 Refs: #9111 Refs: #10052 Fixes: #8012 PR-URL: #8016 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Josh Gavant <josh.gavant@outlook.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 21, 2016
Instead of excluding IDE-specific dotfiles, exclude all and then whitelist those the project needs to track. Refs: #8010 Refs: #9111 Refs: #10052 Fixes: #8012 PR-URL: #8016 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Josh Gavant <josh.gavant@outlook.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 21, 2016
Instead of excluding IDE-specific dotfiles, exclude all and then whitelist those the project needs to track. Refs: #8010 Refs: #9111 Refs: #10052 Fixes: #8012 PR-URL: #8016 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Josh Gavant <josh.gavant@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
tools
Description of change
Add .idea/ to .gitignore to make it easier to work on Node with JetBrains IDEs.
Covers all JetBrains IDEs: IntelliJ, AppCode, PyCharm, CLion, Android Studio, Webstorm and others
Similar to recently landed PR #7967