Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport fs added: info #7679

Closed
wants to merge 3 commits into from
Closed

Backport fs added: info #7679

wants to merge 3 commits into from

Commits on Jul 12, 2016

  1. doc: adds 'close' events to fs.ReadStream and fs.WriteStream 

    Add 'close' event to doc/api/fs.md --> fs.ReadStream
Add 'close' event to doc/api/fs.md --> fs.WriteStream
Add 'close event to doc/api/stream.md --> stream.Writable

From squashed history:
Add 'close' event to stream.Writable per Issue nodejs#6484
Add #### prefix to Event: 'close' and backticks to 'close'
similar to stream.Readable event: 'close' section
Add more specifics to 'close' events for fs.ReadStream
and fs.WriteStream
Fix/Changed 'close' event from 'fs.ReadStream' to 'fs.WriteStream'
wrapped long lines at 80 chars, reworded
per Issue nodejs#6484
including the 'close' event as optional
add 'close' event as optional in stream.Readable
per issue nodejs#6484
doc: Add 'close' events to fs.ReadStream, 80char nit

Fixes: nodejs#6484
PR-URL: nodejs#6499
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Robert Jefe Lindstaedt <robert.lindstaedt@gmail.com>
    @addaleax
    Jenna Vuong authored and addaleax committed Jul 12, 2016
    Configuration menu
    Copy the full SHA
    1aa955a View commit details
    Browse the repository at this point in the history

  2. doc: add added: information for fs 

    Ref: nodejs#6578
PR-URL: nodejs#6717
Reviewed-By: Robert Lindstaedt <robert.lindstaedt@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
    @addaleax
    addaleax committed Jul 12, 2016
    Configuration menu
    Copy the full SHA
    3c398de View commit details
    Browse the repository at this point in the history

  3. doc: correct added: information for fs.access 

    fs.access and fs.accessSync were added to Node v0.11.15 via 2944934

PR-URL: nodejs#7299
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Ref: nodejs#6717
Ref: nodejs#6578
    @richardlau @addaleax
    richardlau authored and addaleax committed Jul 12, 2016
    Configuration menu
    Copy the full SHA
    cb8fae6 View commit details
    Browse the repository at this point in the history