Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

child_process: workaround fd passing issue on OS X #7572

Merged
merged 1 commit into from
Aug 20, 2016

Commits on Aug 20, 2016

  1. child_process: workaround fd passing issue on OS X

    There's an issue on some `OS X` versions when passing fd's between processes.
    When the handle associated to a specific file descriptor is closed by the sender
    process before it's received in the destination, the handle is indeed closed
    while it should remain opened. In order to fix this behaviour, don't close the
    handle until the `NODE_HANDLE_ACK` is received by the sender.
    Added `test-child-process-pass-fd` that is basically `test-cluster-net-send` but
    creating lots of workers, so the issue reproduces on `OS X` consistently.
    
    Fixes: nodejs#7512
    PR-URL: nodejs#7572
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    santigimeno committed Aug 20, 2016
    Configuration menu
    Copy the full SHA
    db6253f View commit details
    Browse the repository at this point in the history