Skip to content

Conversation

addaleax
Copy link
Member

@addaleax addaleax commented Jul 5, 2016

Fix a s/addon/addons/ typo in the Makefile.

CI: https://ci.nodejs.org/job/node-test-commit/3974/

Fix a `s/addon/addons/` typo in the Makefile.
@addaleax addaleax added the test Issues and PRs related to the tests. label Jul 5, 2016
@nodejs-github-bot nodejs-github-bot added the build Issues and PRs related to build files or the CI. label Jul 5, 2016
@cjihrig
Copy link
Contributor

cjihrig commented Jul 5, 2016

LGTM

1 similar comment
@jasnell
Copy link
Member

jasnell commented Jul 5, 2016

LGTM

@bnoordhuis
Copy link
Member

Ai, did I really misspell that? LGTM.

@addaleax
Copy link
Member Author

addaleax commented Jul 5, 2016

Landed in 1fe0708

@addaleax addaleax closed this Jul 5, 2016
@addaleax addaleax deleted the really-run-addon-tests branch July 5, 2016 21:09
addaleax added a commit that referenced this pull request Jul 5, 2016
Fix a `s/addon/addons/` typo in the Makefile.

PR-URL: #7542
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
@Fishrock123
Copy link
Contributor

OH

good catch!

Fishrock123 pushed a commit that referenced this pull request Jul 6, 2016
Fix a `s/addon/addons/` typo in the Makefile.

PR-URL: #7542
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
@Fishrock123 Fishrock123 mentioned this pull request Jul 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Issues and PRs related to build files or the CI. test Issues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants